Do some miscellaneous code cleanup.

Review Request #7906 — Created Jan. 25, 2016 and submitted

david
student-sonar
master
1ff66bc...
student-sonar

This primarily is just switching out let for const where we can, but
there's also some formatting changes and a couple places where promises could
be used more effectively.

Flipped through all the affected pages and saw that things still worked as
expected.

Description From Last Updated

Can we use let .. of .. here?

brenniebrennie

Why not put this with the require()s at the top of the file?

brenniebrennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        lib/config.js
        bin/load-slack-users
        lib/init.js
        lib/cache.js
        lib/frontend/application-view.js
        lib/asana.js
        lib/slack.js
        lib/routes.js
        lib/reviewboard.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        lib/config.js
        bin/load-slack-users
        lib/init.js
        lib/cache.js
        lib/frontend/application-view.js
        lib/asana.js
        lib/slack.js
        lib/routes.js
        lib/reviewboard.js
    
    
  2. 
      
brennie
  1. 
      
  2. lib/config.js (Diff revision 1)
     
     
     

    Can we use let .. of .. here?

    1. Hmm, for...of with Object.keys probably does the right thing here.

  3. lib/routes.js (Diff revision 1)
     
     

    Why not put this with the require()s at the top of the file?

  4. 
      
david
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        lib/config.js
        bin/load-slack-users
        lib/init.js
        lib/cache.js
        lib/frontend/application-view.js
        lib/asana.js
        lib/slack.js
        lib/routes.js
        lib/reviewboard.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        lib/config.js
        bin/load-slack-users
        lib/init.js
        lib/cache.js
        lib/frontend/application-view.js
        lib/asana.js
        lib/slack.js
        lib/routes.js
        lib/reviewboard.js
    
    
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (847ff37)
Loading...