Summary

Do some miscellaneous code cleanup.

Review Request #7906 — Created Jan. 25, 2016 and submitted Jan. 26, 2016, 3:17 p.m.

Information

Owner

david

Repository

student-sonar

Branch

master

Bugs

Depends On

Commit

1ff66bc...

Reviewers

Groups

student-sonar

People

Description

This primarily is just switching out let for const where we can, but

there's also some formatting changes and a couple places where promises could

be used more effectively.

Testing Done

Flipped through all the affected pages and saw that things still worked as
expected.

Issues

Description	From	Last Updated
Can we use let .. of .. here?	brennie	Jan. 26, 2016, 2:51 p.m.
Why not put this with the require()s at the top of the file?	brennie	Jan. 26, 2016, 2:54 p.m.

Tool: PEP8 Style Checker
Ignored Files:
    lib/config.js
    bin/load-slack-users
    lib/init.js
    lib/cache.js
    lib/frontend/application-view.js
    lib/asana.js
    lib/slack.js
    lib/routes.js
    lib/reviewboard.js



Tool: Pyflakes
Ignored Files:
    lib/config.js
    bin/load-slack-users
    lib/init.js
    lib/cache.js
    lib/frontend/application-view.js
    lib/asana.js
    lib/slack.js
    lib/routes.js
    lib/reviewboard.js

Ship it!

lib/config.js (Diff revision 1)

The issue has been resolved. Show all issues

Can we use let .. of .. here?

david Jan. 26, 2016, 2:54 p.m.

Hmm, for...of with Object.keys probably does the right thing here.

lib/routes.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Why not put this with the require()s at the top of the file?
```

Commit:

2cf9265c8ad596a4502c9844a49108933af24131

1ff66bcb86e1936e70c8a5ac47ac0f3a4308cd0a

Diff:

Revision 2 (+85 -100)

Show changes

	bin/load-slack-users
	lib/asana.js
	lib/cache.js
	lib/config.js
	lib/init.js
	lib/reviewboard.js
	lib/routes.js
	lib/slack.js
	1 more

Tool: Pyflakes
Ignored Files:
    lib/config.js
    bin/load-slack-users
    lib/init.js
    lib/cache.js
    lib/frontend/application-view.js
    lib/asana.js
    lib/slack.js
    lib/routes.js
    lib/reviewboard.js



Tool: PEP8 Style Checker
Ignored Files:
    lib/config.js
    bin/load-slack-users
    lib/init.js
    lib/cache.js
    lib/frontend/application-view.js
    lib/asana.js
    lib/slack.js
    lib/routes.js
    lib/reviewboard.js

Status:: Completed
Change Summary:: Pushed to master (847ff37)