Add code reviews to sonar.

Review Request #7889 — Created Jan. 17, 2016 and submitted

Information

student-sonar
master
be8df5c...

Reviewers

This change adds links to code reviews inside sonar. This depends on /r/7888 to
actually get the URL to the code review, and there's currently no good text to
put in the link, but it will at least give us a list of links we can see and
copy/paste.

This also adds a spinner to the review request list while it's loading.

Looked at a page that had both review requests and reviews.

Description From Last Updated

Do we want this as a class-level constant? We're using it in multiple places.

brenniebrennie
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        lib/api.js
        css/style.less
        lib/reviewboard.js
        lib/frontend/user-detail-view.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        lib/api.js
        css/style.less
        lib/reviewboard.js
        lib/frontend/user-detail-view.js
    
    
  2. 
      
SM
  1. 
      
  2. lib/frontend/user-detail-view.js (Diff revision 1)
     
     
    1. In a pinch, "review of [REVIEWREQ#]" is probably a decent bet. Distinguishes, and comment / title / line of code commented on aren't really good replacements.
    2. Though, "Review of [user's] request [REVIEWREQ#]" might be useful? Since it's for students, and students only work on one thing, knowing who wrote the review request will often be enough to know what got reviewed
  3. 
      
brennie
  1. 
      
  2. lib/frontend/user-detail-view.js (Diff revision 1)
     
     

    Do we want this as a class-level constant? We're using it in multiple places.

  3. 
      
david
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        lib/api.js
        css/style.less
        lib/reviewboard.js
        lib/frontend/user-detail-view.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        lib/api.js
        css/style.less
        lib/reviewboard.js
        lib/frontend/user-detail-view.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (1844896)
Loading...