[WIP] working to create a floating file index list banner that follows you down the page
Review Request #7885 — Created Jan. 16, 2016 and discarded
| Information | |
|---|---|
| smith | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard | |
[WIP] working to create a floating file index list banner that follows you down the page
Haven't even plugged this in yet, commiting as WIP
SM
Change Summary:
just making sure the (very basic) css changes don't get forgotten - the file index list is display: none on page-load, so it needs a class for that
Diff: |
Revision 2 (+65) |
|---|
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/diffviewer/views/FileIndexFloatBanner.js reviewboard/static/rb/css/pages/diffviewer.less Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/diffviewer/views/FileIndexFloatBanner.js reviewboard/static/rb/css/pages/diffviewer.less
SM
Change Summary:
Still sloppy-looking! This is a "try to get it appear in the DOM" test.
Diff: |
Revision 3 (+80 -2) |
|---|
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/diffviewer/views/fileIndexFloatBanner.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js reviewboard/static/rb/css/pages/diffviewer.less Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/diffviewer/views/fileIndexFloatBanner.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js reviewboard/static/rb/css/pages/diffviewer.less
-
-
reviewboard/static/rb/js/pages/views/diffViewerPageView.js (Diff revision 3) Passing in the
elis only for when the element already exists and you want the view to take ownership of it. In this case, probably we want to let the view create a new element and then we can attach it to the DOM. So don't includeelin your options. -
reviewboard/static/rb/js/pages/views/diffViewerPageView.js (Diff revision 3) The view is not the element, it contains the element. This probably should be
$('div.box.reviewrequest').append(this._fileListFollowBanner.$el)
SM
Change Summary:
Removing el as per fixes. Playing around with bubbling an event through.
Next issue is understanding floatContainer, likely.
Diff: |
Revision 4 (+79 -2) |
|---|
-
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/diffviewer/views/fileIndexFloatBanner.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js reviewboard/static/rb/css/pages/diffviewer.less Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/rb/js/diffviewer/views/fileIndexFloatBanner.js reviewboard/static/rb/js/pages/views/diffViewerPageView.js reviewboard/static/rb/css/pages/diffviewer.less
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/diffviewer/views/FileIndexFloatBanner.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/diffviewer/views/FileIndexFloatBanner.js