[WIP] working to create a floating file index list banner that follows you down the page

Review Request #7885 — Created Jan. 16, 2016 and discarded

smith
Review Board
master
reviewboard
[WIP] working to create a floating file index list banner that follows you down the page
Haven't even plugged this in yet, commiting as WIP
Description From Last Updated

Passing in the el is only for when the element already exists and you want the view to take ownership ...

daviddavid

The view is not the element, it contains the element. This probably should be $('div.box.reviewrequest').append(this._fileListFollowBanner.$el)

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/FileIndexFloatBanner.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/FileIndexFloatBanner.js
    
    
  2. 
      
SM
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/FileIndexFloatBanner.js
        reviewboard/static/rb/css/pages/diffviewer.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/FileIndexFloatBanner.js
        reviewboard/static/rb/css/pages/diffviewer.less
    
    
  2. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/fileIndexFloatBanner.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
        reviewboard/static/rb/css/pages/diffviewer.less
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/fileIndexFloatBanner.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
        reviewboard/static/rb/css/pages/diffviewer.less
    
    
  2. 
      
david
  1. 
      
  2. Passing in the el is only for when the element already exists and you want the view to take ownership of it. In this case, probably we want to let the view create a new element and then we can attach it to the DOM. So don't include el in your options.

  3. The view is not the element, it contains the element. This probably should be $('div.box.reviewrequest').append(this._fileListFollowBanner.$el)

  4. 
      
SM
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/fileIndexFloatBanner.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
        reviewboard/static/rb/css/pages/diffviewer.less
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/diffviewer/views/fileIndexFloatBanner.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
        reviewboard/static/rb/css/pages/diffviewer.less
    
    
  2. 
      
SM
Review request changed

Status: Discarded

Change Summary:

we're taking a different tack on this one - using the extant review banner

Loading...