- Download Diff

Summary:

[WIP] Publishing possible from the Web API when no reviewers or groups specified

Review Request #7882 — Created Jan. 16, 2016 and discarded Jan. 18, 2016, 7:54 a.m.

Information
Owner:	nfredette
Repository:	Review Board
Branch:	master
Bugs:	4057
Depends On:
Reviewers
Groups:	reviewboard, students
People:

Description

added call to can_publish from publish in review_request.py

added checks for reviewers in can_publish

TODO: create automated test

Testing Done

Issues

Description	From	Last Updated
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 16, 2016, 9:48 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 16, 2016, 9:48 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 16, 2016, 9:48 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 16, 2016, 9:54 a.m.
Col: 13 W503 line break before binary operator	reviewbot	Jan. 16, 2016, 11:34 a.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Jan. 16, 2016, 11:34 a.m.
Col: 46 W291 trailing whitespace	reviewbot	Jan. 16, 2016, 11:27 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 16, 2016, 11:27 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 16, 2016, 11:27 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 16, 2016, 11:27 a.m.
Col: 13 W503 line break before binary operator	reviewbot	Jan. 16, 2016, 11:35 a.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Jan. 16, 2016, 11:35 a.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Jan. 16, 2016, 11:33 a.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Jan. 16, 2016, 11:33 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/models/review_request.py

reviewboard/reviews/models/review_request.py (Diff revision 1)
Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/models/review_request.py (Diff revision 1)
Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/reviews/models/review_request.py (Diff revision 1)
Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/reviews/models/review_request.py (Diff revision 1)
Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/reviews/models/review_request.py (Diff revision 1)
Show all issues
```
Col: 13
 W503 line break before binary operator
```
reviewboard/reviews/models/review_request.py (Diff revision 1)
Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```

Diff:

Revision 2 (+13 -3)

Show changes

reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/models/review_request.py

reviewboard/reviews/models/review_request.py (Diff revision 2)
Show all issues
```
Col: 46
 W291 trailing whitespace
```
reviewboard/reviews/models/review_request.py (Diff revision 2)
Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/reviews/models/review_request.py (Diff revision 2)
Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/reviews/models/review_request.py (Diff revision 2)
Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/reviews/models/review_request.py (Diff revision 2)
Show all issues
```
Col: 13
 W503 line break before binary operator
```
reviewboard/reviews/models/review_request.py (Diff revision 2)
Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```

Please put the bug number into the "bugs" field instead of the summary.

Summary:

-	[WIP] Resolved ticket 4057 - Publishing possible from the Web API when no reviewers or groups specified
+	[WIP] Publishing possible from the Web API when no reviewers or groups specified

Bugs:

+	4057

Change Summary:

Adding to the students group

Groups:

+	students

Diff:

Revision 3 (+13 -3)

Show changes

reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/models/review_request.py

reviewboard/reviews/models/review_request.py (Diff revision 3)
Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/models/review_request.py (Diff revision 3)
Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```

Diff:

Revision 4 (+13 -3)

Show changes

reviewboard/reviews/models/review_request.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/models/review_request.py

Is this an old review now? Looks very much like the other. (Best to reuse review requests centered around a change, rather than creating new ones.)

You have a pending review.

Review Board 5.0.2 alpha 0 (dev)

[WIP] Publishing possible from the Web API when no reviewers or groups specified

Diff:

Summary:

Bugs:

Change Summary:

Groups:

Diff:

Diff:

Status: Discarded