[WIP] Publishing possible from the Web API when no reviewers or groups specified

Review Request #7882 — Created Jan. 16, 2016 and discarded

Information

Review Board
master

Reviewers

added call to can_publish from publish in review_request.py

added checks for reviewers in can_publish

TODO: create automated test


 
Description From Last Updated

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 13 W503 line break before binary operator

reviewbotreviewbot

Col: 13 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 46 W291 trailing whitespace

reviewbotreviewbot

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 13 W503 line break before binary operator

reviewbotreviewbot

Col: 13 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 13 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 13 E128 continuation line under-indented for visual indent

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/models/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/models/review_request.py
    
    
  2. Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  3. Show all issues
    Col: 1
     W191 indentation contains tabs
    
  4. Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  5. Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  6. Show all issues
    Col: 13
     W503 line break before binary operator
    
  7. Show all issues
    Col: 13
     E128 continuation line under-indented for visual indent
    
  8. 
      
NF
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/models/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/models/review_request.py
    
    
  2. Show all issues
    Col: 46
     W291 trailing whitespace
    
  3. Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  4. Show all issues
    Col: 1
     W191 indentation contains tabs
    
  5. Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  6. Show all issues
    Col: 13
     W503 line break before binary operator
    
  7. Show all issues
    Col: 13
     E128 continuation line under-indented for visual indent
    
  8. 
      
david
  1. Please put the bug number into the "bugs" field instead of the summary.

  2. 
      
NF
NF
NF
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/models/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/models/review_request.py
    
    
  2. Show all issues
    Col: 13
     E128 continuation line under-indented for visual indent
    
  3. Show all issues
    Col: 13
     E128 continuation line under-indented for visual indent
    
  4. 
      
NF
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/models/review_request.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/models/review_request.py
    
    
  2. 
      
chipx86
  1. Is this an old review now? Looks very much like the other. (Best to reuse review requests centered around a change, rather than creating new ones.)

  2. 
      
NF
Review request changed
Status:
Discarded