Fix interdiffs for deleted in a revision then modified in the future.

Review Request #7874 — Created Jan. 15, 2016 and discarded

smacleod
Review Board
release-2.5.x
4052
reviewboard
chipx86
A filediff for an interdiff would always display as deleted if it had
been deleted in the first revision, even if the future revision no
longer deleted the file. We now take the future filediff into account
when calculating the deleted status.

./reviewboard/manage.py test -- reviewboard.diffviewer.tests

Description From Last Updated

Blank line between these.

brenniebrennie

Col: 80 E501 line too long (83 > 79 characters)

reviewbotreviewbot

Single quotes.

brenniebrennie

local variable 'mod_filediff' is assigned to but never used

reviewbotreviewbot

Missing a period.

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/diffutils.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/testing/testcase.py
        reviewboard/diffviewer/tests.py
        reviewboard/diffviewer/diffutils.py
    
    
  2. reviewboard/diffviewer/tests.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (83 > 79 characters)
    
  3. reviewboard/diffviewer/tests.py (Diff revision 1)
     
     
     local variable 'mod_filediff' is assigned to but never used
    
  4. 
      
brennie
  1. 
      
  2. reviewboard/diffviewer/tests.py (Diff revision 1)
     
     
     

    Blank line between these.

  3. reviewboard/diffviewer/tests.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Single quotes.

  4. reviewboard/diffviewer/tests.py (Diff revision 1)
     
     

    Missing a period.

  5. 
      
david
Review request changed

Status: Discarded

Loading...