Summary

Fix interdiffs for deleted in a revision then modified in the future.

Review Request #7874 — Created Jan. 15, 2016 and discarded Jan. 29, 2019, 1:41 p.m.

Information

Owner

smacleod

Repository

Review Board

Branch

release-2.5.x

Bugs

4052

Depends On

Reviewers

Groups

reviewboard

People

chipx86

Description

A filediff for an interdiff would always display as deleted if it had
been deleted in the first revision, even if the future revision no
longer deleted the file. We now take the future filediff into account
when calculating the deleted status.

Testing Done

./reviewboard/manage.py test -- reviewboard.diffviewer.tests

Issues

Description	From	Last Updated
Blank line between these.	brennie	Jan. 17, 2016, 6:32 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Jan. 15, 2016, 2:15 p.m.
Single quotes.	brennie	Jan. 17, 2016, 6:32 a.m.
local variable 'mod_filediff' is assigned to but never used	reviewbot	Jan. 15, 2016, 2:15 p.m.
Missing a period.	brennie	Jan. 17, 2016, 6:32 a.m.

Fix it!

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/diffutils.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/diffviewer/tests.py
    reviewboard/diffviewer/diffutils.py

reviewboard/diffviewer/tests.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/diffviewer/tests.py (Diff revision 1)
An issue was opened. Show all issues
```
 local variable 'mod_filediff' is assigned to but never used
```

Fix it!

reviewboard/diffviewer/tests.py (Diff revision 1)
An issue was opened. Show all issues
```
Blank line between these.
```

reviewboard/diffviewer/tests.py (Diff revision 1)

An issue was opened. Show all issues

Single quotes.

reviewboard/diffviewer/tests.py (Diff revision 1)
An issue was opened. Show all issues
```
Missing a period.
```

Status:: Discarded