Summary

Create extension for auto-assigning students to the students group

Review Request #7872 — Created Jan. 15, 2016 and submitted Jan. 22, 2016, 6:47 a.m.

Information

Owner

mike_conley

Repository

student-sonar

Branch

master

Bugs

Depends On

Commit

5750492...

Reviewers

Groups

student-sonar

People

Description

A simple extension for auto-assigning students working on Review Board to
the "students" group.

I can imagine this maybe being useful for other projects as well, so I can
see this expanding out to allow multiple auto-assignments, but for now I've
just hard-coded the "students" group.

Testing Done

Created some test users and a "students" group. Entered the extension
configuration page and added some users in the comma-separated list to
auto-assign. Created review requests for the users in the list and saw
that they were correctly added to the "students" group. The review requests
from the other users were not.

Also verified that the "open" counts in the dashboard for the group
was updated correctly after creating an auto-assigned review request.

Issues

Description	From	Last Updated
Also a lie!	david	Jan. 15, 2016, 2:23 p.m.
This is a lie.	david	Jan. 15, 2016, 2:23 p.m.
Swap these two lines.	david	Jan. 17, 2016, 8:48 a.m.
This is impossible.	david	Jan. 17, 2016, 8:48 a.m.
These could be combined into a single assignment: assignees = [ s.strip() for s in self.settings.get('assignees').split(',') ]	david	Jan. 17, 2016, 8:49 a.m.
This should probably be logging.debug.	david	Jan. 17, 2016, 8:49 a.m.
No blank line here.	david	Jan. 17, 2016, 8:49 a.m.
Localize this too?	david	Jan. 17, 2016, 8:50 a.m.
Col: 22 E128 continuation line under-indented for visual indent	reviewbot	Jan. 17, 2016, 8:58 a.m.

Tool: PEP8 Style Checker
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/forms.py
    misc/rb-auto-assigner/rb_auto_assigner/extension.py
    misc/rb-auto-assigner/setup.py
    misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py

Ignored Files:
    misc/rb-auto-assigner/rb_auto_assigner/__init__.py



Tool: Pyflakes
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/forms.py
    misc/rb-auto-assigner/rb_auto_assigner/extension.py
    misc/rb-auto-assigner/setup.py
    misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py

Ignored Files:
    misc/rb-auto-assigner/rb_auto_assigner/__init__.py

Originally posted for review for the rb-extension-pack repo here: https://reviews.reviewboard.org/r/7856/

Please also see my comments on pre_save on your other review request for this.

mike_conley Jan. 16, 2016, 7:08 a.m.

Done. I ended up having to use post_save, otherwise I got an error attempting to fiddle with the ManyToMany relationship:

2016-01-16 06:55:37,323 - ERROR -  - Error when calling <bound method RBAutoAssigner.on_pre_save of <rb_auto_assigner.extension.RBAutoAssigner object at 0x10cfb32d0>> from SignalHook: "<ReviewRequest: (no summary)>" needs to have a value for field "reviewrequest" before this many-to-many relationship can be used.
Traceback (most recent call last):
  File "/Users/mikeconley/Projects/rb-vm-dev/src/djblets/djblets/extensions/hooks.py", line 439, in _wrap_callback
    self.callback(extension=self.extension, **kwargs)
  File "/Users/mikeconley/Projects/rb-vm-dev/src/student-sonar/misc/rb-auto-assigner/rb_auto_assigner/extension.py", line 58, in on_pre_save
    instance.target_groups.add(group)
  File "/usr/local/lib/python2.7/site-packages/django/db/models/fields/related.py", line 827, in __get__
    through=self.field.rel.through,
  File "/usr/local/lib/python2.7/site-packages/django/db/models/fields/related.py", line 524, in __init__
    (instance, source_field_name))
ValueError: "<ReviewRequest: (no summary)>" needs to have a value for field "reviewrequest" before this many-to-many relationship can be used.

misc/rb-auto-assigner/rb_auto_assigner/extension.py (Diff revision 1)
Show all issues
```
Also a lie!
```
misc/rb-auto-assigner/setup.py (Diff revision 1)
Show all issues
```
This is a lie.
```

Change Summary:

Switched to a post_save signal handler for ReviewRequest to add the group.

Commit:

-	23a4c24c0d57bb49cbff778619cbf6173f97b800
+	0783739d439d2665f9ca8c7ebbbd318d01b89f9b

Diff:

Revision 2 (+114)

Show changes

	misc/rb-auto-assigner/setup.py
	misc/rb-auto-assigner/rb_auto_assigner/__init__.py
	misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py
	misc/rb-auto-assigner/rb_auto_assigner/extension.py
	misc/rb-auto-assigner/rb_auto_assigner/forms.py

Tool: Pyflakes
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/forms.py
    misc/rb-auto-assigner/rb_auto_assigner/extension.py
    misc/rb-auto-assigner/setup.py
    misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py

Ignored Files:
    misc/rb-auto-assigner/rb_auto_assigner/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/forms.py
    misc/rb-auto-assigner/rb_auto_assigner/extension.py
    misc/rb-auto-assigner/setup.py
    misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py

Ignored Files:
    misc/rb-auto-assigner/rb_auto_assigner/__init__.py

misc/rb-auto-assigner/rb_auto_assigner/extension.py (Diff revision 2)
Show all issues
```
Swap these two lines.
```
misc/rb-auto-assigner/rb_auto_assigner/extension.py (Diff revision 2)
Show all issues
```
This is impossible.
```

misc/rb-auto-assigner/rb_auto_assigner/extension.py (Diff revision 2)

Show all issues

These could be combined into a single assignment:

assignees = [
    s.strip() for s in
    self.settings.get('assignees').split(',')
]

misc/rb-auto-assigner/rb_auto_assigner/extension.py (Diff revision 2)
Show all issues
```
This should probably be logging.debug.
```

misc/rb-auto-assigner/rb_auto_assigner/extension.py (Diff revision 2)

Can you verify that the open counts in the dashboard are updated correctly for this?

mike_conley Jan. 17, 2016, 8:53 a.m.

Yep, after publishing, it looks like the counts are updated for the group.

misc/rb-auto-assigner/rb_auto_assigner/forms.py (Diff revision 2)
Show all issues
```
No blank line here.
```
misc/rb-auto-assigner/rb_auto_assigner/forms.py (Diff revision 2)
Show all issues
```
Localize this too?
```

Commit:

-	0783739d439d2665f9ca8c7ebbbd318d01b89f9b
+	f9414c5c827b84915f895e31952c4b86ca7b3475

Diff:

Revision 3 (+110)

Show changes

	misc/rb-auto-assigner/setup.py
	misc/rb-auto-assigner/rb_auto_assigner/__init__.py
	misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py
	misc/rb-auto-assigner/rb_auto_assigner/extension.py
	misc/rb-auto-assigner/rb_auto_assigner/forms.py

Tool: PEP8 Style Checker
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/forms.py
    misc/rb-auto-assigner/rb_auto_assigner/extension.py
    misc/rb-auto-assigner/setup.py
    misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py

Ignored Files:
    misc/rb-auto-assigner/rb_auto_assigner/__init__.py



Tool: Pyflakes
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/forms.py
    misc/rb-auto-assigner/rb_auto_assigner/extension.py
    misc/rb-auto-assigner/setup.py
    misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py

Ignored Files:
    misc/rb-auto-assigner/rb_auto_assigner/__init__.py

misc/rb-auto-assigner/rb_auto_assigner/extension.py (Diff revision 3)
Show all issues
```
Col: 22
 E128 continuation line under-indented for visual indent
```

Commit:

-	f9414c5c827b84915f895e31952c4b86ca7b3475
+	5750492e3ea57a7170f3dad1d75f0281c71e7ca5

Diff:

Revision 4 (+110)

Show changes

	misc/rb-auto-assigner/setup.py
	misc/rb-auto-assigner/rb_auto_assigner/__init__.py
	misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py
	misc/rb-auto-assigner/rb_auto_assigner/extension.py
	misc/rb-auto-assigner/rb_auto_assigner/forms.py

Tool: Pyflakes
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/forms.py
    misc/rb-auto-assigner/rb_auto_assigner/extension.py
    misc/rb-auto-assigner/setup.py
    misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py

Ignored Files:
    misc/rb-auto-assigner/rb_auto_assigner/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    misc/rb-auto-assigner/rb_auto_assigner/forms.py
    misc/rb-auto-assigner/rb_auto_assigner/extension.py
    misc/rb-auto-assigner/setup.py
    misc/rb-auto-assigner/rb_auto_assigner/admin_urls.py

Ignored Files:
    misc/rb-auto-assigner/rb_auto_assigner/__init__.py

Testing Done:

		Created some test users and a "students" group. Entered the extension
		configuration page and added some users in the comma-separated list to
		auto-assign. Created review requests for the users in the list and saw
		that they were correctly added to the "students" group. The review requests
		from the other users were not.
	+
	+	Also verified that the "open" counts in the dashboard for the group
	+	was updated correctly after creating an auto-assigned review request.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (f294119)