Update diff "Start Over" text is now inside of patch dialog box

Review Request #7871 — Created Jan. 15, 2016 and submitted

Information

Review Board
release-2.5.x

Reviewers

The "Start Over" text in the Update diff dialog was floating in
free space below the box. This was due to huge line spacing.
Now the "Start Over" text sits in the bottom right-hand corner of
the dialog box.

Similarly, the contents of the dialog box were off centre and were
touching the border, which looked bad.
Now the contents are centered both vertically and horizontally
which looks much nicer.

These changes were tested in Chrome 47, Firefox 43, and Safari 9
by viewing them in each browser and nothing seemed broken.

The bug could not be reproduced with these changes implemented.


Description From Last Updated

There's a bunch of trailing whitespace in here.

daviddavid

calc is experimental and we can't use it. We should instead use margins.

daviddavid

transform is also experimental. We should use a sized element and margin: auto to do the centering.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/updateDiffView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/updateDiffView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
SA
david
  1. Can you add the bug number to this?

  2. reviewboard/static/rb/css/pages/reviews.less (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    There's a bunch of trailing whitespace in here.

  3. Show all issues

    calc is experimental and we can't use it. We should instead use margins.

    1. Are you sure? According to the MDN doc, it's supported in:

      Firefox 16+
      Chrome 26+
      IE9+
      Safari 7+

    2. It also says "this technology's specification has not stabilized"

    3. Fair enough! :D

  4. Show all issues

    transform is also experimental. We should use a sized element and margin: auto to do the centering.

  5. 
      
chipx86
  1. Would you mind adding screenshots of the before and after for the dialog? Screenshots are really helpful for UI changes.

  2. 
      
SA
SA
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/updateDiffView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/updateDiffView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
SA
SA
mike_conley
  1. Looks good to me! Thanks!

  2. 
      
david
  1. Ship It!
  2. 
      
SA
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (87072a4)