Summary

Skipping p4 and svn requiring tests in test_assembla.py if those modules are not present

Review Request #7867 — Created Jan. 15, 2016 and submitted Jan. 15, 2016, 9:07 a.m.

Information

Owner

smith

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Certain tests in test_assembla.py which involve importing P4 or svn integration fail if those modules aren't installed.
I think we should skip them instead!

Now we respond to an ImportError being raised by skipping that test.

Testing Done

Ran unit tests in test_assembla.py - four tests that previously failed due to ImportError are now skipped.

Issues

Description	From	Last Updated
Col: 10 E111 indentation is not a multiple of four	reviewbot	Jan. 15, 2016, 7:43 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 15, 2016, 7:43 a.m.
Col: 10 E111 indentation is not a multiple of four	reviewbot	Jan. 15, 2016, 7:43 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 15, 2016, 7:43 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 15, 2016, 7:43 a.m.
Col: 10 E111 indentation is not a multiple of four	reviewbot	Jan. 15, 2016, 7:43 a.m.
Col: 10 E111 indentation is not a multiple of four	reviewbot	Jan. 15, 2016, 7:43 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 15, 2016, 7:43 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 15, 2016, 7:43 a.m.
Imports in python should be grouped into three categories, with one blank line in between each: Standard library Third-party This …	david	Jan. 15, 2016, 8:14 a.m.
Indentation is now misaligned because you indented the first line but not the second. tool should line up with hosting_account.	david	Jan. 15, 2016, 8:04 a.m.
Indentation got messed up here.	david	Jan. 15, 2016, 8:04 a.m.
Indentation got messed up here.	david	Jan. 15, 2016, 8:04 a.m.
Indentation got messed up here.	david	Jan. 15, 2016, 8:04 a.m.
Indentation got messed up here.	david	Jan. 15, 2016, 8:04 a.m.
Indentation got messed up here.	david	Jan. 15, 2016, 8:04 a.m.
Indentation needs to be fixed here.	david	Jan. 15, 2016, 8:21 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py

reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
Show all issues
```
Col: 10
 E111 indentation is not a multiple of four
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
Show all issues
```
Col: 10
 E111 indentation is not a multiple of four
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
Show all issues
```
Col: 10
 E111 indentation is not a multiple of four
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 1)
Show all issues
```
Col: 10
 E111 indentation is not a multiple of four
```

Diff:

Revision 2 (+52 -39)

Show changes

reviewboard/hostingsvcs/tests/test_assembla.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py

reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 2)
Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 2)
Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```

Change Summary:

fixing whitespace, basically

Diff:

Revision 3 (+52 -39)

Show changes

reviewboard/hostingsvcs/tests/test_assembla.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py

reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)

Show all issues

Imports in python should be grouped into three categories, with one blank line in between each:

Standard library
Third-party
This package

In this case, that means you should have:

import nose

from reviewboard.hostingsvcs.tests.testcases import ServiceTests
...

reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)

Show all issues

Indentation is now misaligned because you indented the first line but not the second. tool should line up with hosting_account.

reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
Show all issues
```
Indentation got messed up here.
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
Show all issues
```
Indentation got messed up here.
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
Show all issues
```
Indentation got messed up here.
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
Show all issues
```
Indentation got messed up here.
```
reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
Show all issues
```
Indentation got messed up here.
```

Change Summary:

Further cleaning - making sure function arguments line up, grouping imports

Diff:

Revision 4 (+74 -60)

Show changes

reviewboard/hostingsvcs/tests/test_assembla.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py

reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 4)
Show all issues
```
Indentation needs to be fixed here.
```

Diff:

Revision 5 (+75 -61)

Show changes

reviewboard/hostingsvcs/tests/test_assembla.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/tests/test_assembla.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (71a80f3)