Skipping p4 and svn requiring tests in test_assembla.py if those modules are not present

Review Request #7867 — Created Jan. 15, 2016 and submitted

Information

Review Board
master

Reviewers

Certain tests in test_assembla.py which involve importing P4 or svn integration fail if those modules aren't installed.
I think we should skip them instead!

Now we respond to an ImportError being raised by skipping that test.

Ran unit tests in test_assembla.py - four tests that previously failed due to ImportError are now skipped.

Description From Last Updated

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Imports in python should be grouped into three categories, with one blank line in between each: Standard library Third-party This …

daviddavid

Indentation is now misaligned because you indented the first line but not the second. tool should line up with hosting_account.

daviddavid

Indentation got messed up here.

daviddavid

Indentation got messed up here.

daviddavid

Indentation got messed up here.

daviddavid

Indentation got messed up here.

daviddavid

Indentation got messed up here.

daviddavid

Indentation needs to be fixed here.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
  2. Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  3. Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  4. Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  5. Show all issues
    Col: 1
     W191 indentation contains tabs
    
  6. Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  7. Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  8. Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  9. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
  2. Show all issues
    Col: 1
     W191 indentation contains tabs
    
  3. Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  4. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
     
     
     
     
    Show all issues

    Imports in python should be grouped into three categories, with one blank line in between each:

    1. Standard library
    2. Third-party
    3. This package

    In this case, that means you should have:

    import nose
    
    from reviewboard.hostingsvcs.tests.testcases import ServiceTests
    ...
    
  3. Show all issues

    Indentation is now misaligned because you indented the first line but not the second. tool should line up with hosting_account.

  4. reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
     
     
     
     
    Show all issues

    Indentation got messed up here.

  5. Show all issues

    Indentation got messed up here.

  6. reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
     
     
     
     
     
     
     
    Show all issues

    Indentation got messed up here.

  7. reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
     
     
     
     
    Show all issues

    Indentation got messed up here.

  8. reviewboard/hostingsvcs/tests/test_assembla.py (Diff revision 3)
     
     
     
     
     
     
    Show all issues

    Indentation got messed up here.

  9. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
  2. 
      
david
  1. 
      
  2. Show all issues

    Indentation needs to be fixed here.

  3. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests/test_assembla.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
SM
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (71a80f3)
Loading...