Skipping p4 and svn requiring tests in test_assembla.py if those modules are not present
Review Request #7867 — Created Jan. 15, 2016 and submitted
Certain tests in test_assembla.py which involve importing P4 or svn integration fail if those modules aren't installed.
I think we should skip them instead!Now we respond to an ImportError being raised by skipping that test.
Ran unit tests in test_assembla.py - four tests that previously failed due to ImportError are now skipped.
| Description | From | Last Updated | ||
|---|---|---|---|---|
|
Col: 10 E111 indentation is not a multiple of four |
 reviewbot
|
|||
|
Col: 1 W293 blank line contains whitespace |
reviewbot
|
|||
|
Col: 10 E111 indentation is not a multiple of four |
reviewbot
|
|||
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|||
|
Col: 1 E101 indentation contains mixed spaces and tabs |
reviewbot
|
|||
|
Col: 10 E111 indentation is not a multiple of four |
reviewbot
|
|||
|
Col: 10 E111 indentation is not a multiple of four |
reviewbot
|
|||
|
Col: 1 W191 indentation contains tabs |
reviewbot
|
|||
|
Col: 1 E101 indentation contains mixed spaces and tabs |
reviewbot
|
|||
|
Imports in python should be grouped into three categories, with one blank line in between each: Standard library Third-party This … |
 david
|
|||
|
Indentation is now misaligned because you indented the first line but not the second. tool should line up with hosting_account. |
david
|
|||
|
Indentation got messed up here. |
david
|
|||
|
Indentation got messed up here. |
david
|
|||
|
Indentation got messed up here. |
david
|
|||
|
Indentation got messed up here. |
david
|
|||
|
Indentation got messed up here. |
david
|
|||
|
Indentation needs to be fixed here. |
david
|
|||
| There are no open issues | ||||
-
Tool: Pyflakes Processed Files: reviewboard/hostingsvcs/tests/test_assembla.py Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/tests/test_assembla.py
-
-
Imports in python should be grouped into three categories, with one blank line in between each:
- Standard library
- Third-party
- This package
In this case, that means you should have:
import nose from reviewboard.hostingsvcs.tests.testcases import ServiceTests ... -
Indentation is now misaligned because you indented the first line but not the second.
toolshould line up withhosting_account. -
-
-
-
-
SM
- Change Summary:
-
Further cleaning - making sure function arguments line up, grouping imports
- Diff:
-
Revision 4 (+74 -60)
-
Tool: Pyflakes Processed Files: reviewboard/hostingsvcs/tests/test_assembla.py Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/tests/test_assembla.py
Tool: Pyflakes Processed Files: reviewboard/hostingsvcs/tests/test_assembla.py Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/tests/test_assembla.py