• 
      

    Show more detailed errors during diff validation.

    Review Request #7857 — Created Jan. 9, 2016 and submitted

    Information

    Review Board
    release-2.6.x

    Reviewers

    We have some cases where a diff doesn't validate due to an uncaught
    exception or a repository error. A more specific message was stored in
    the 'reason' field, but the general error was still that the diff didn't
    validate.
    
    We now use the actual exception message as the error message, helping
    clients display the correct thing.

    Simulated these exceptions server-side (and tested with invalid licenses
    in Power Pack), and saw the correct error messages in RBTools.

    Description From Last Updated

    undefined name '_'

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/resources/validate_diff.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/resources/validate_diff.py
      
      
    2. Show all issues
       undefined name '_'
      
    3. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/resources/validate_diff.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/resources/validate_diff.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    david
    1. Actually, this is marked for release-2.6.x. Can't we apply this all the way back to 2.0.x?

      1. Yeah, it's just where I had the code. Going to backport it.

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (fe89d01)