• 
      

    Switch to the new centralized templates for admin form pages.

    Review Request #7852 — Created Jan. 7, 2016 and submitted

    Information

    Review Board
    release-2.6.x

    Reviewers

    Djblets has a new set of common admin form templates meant to replace
    the usage of the siteconfig-hosted templates. This doesn't impact Review
    Board much, but we do make use of some now-deprecated templates. This
    switches over to using the new ones where appropriate.

    Tested each of the affected pages.

    Description From Last Updated

    'django_reset' imported but unused

    reviewbotreviewbot

    'from settings_local import *' used; unable to detect undefined names

    reviewbotreviewbot

    'PIPELINE_CSS' imported but unused

    reviewbotreviewbot

    'PIPELINE_JS' imported but unused

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/settings.py
          reviewboard/admin/views.py
      
      Ignored Files:
          reviewboard/templates/admin/authentication_settings.html
          reviewboard/templates/admin/scmtools/repository/change_form.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/settings.py
          reviewboard/admin/views.py
      
      Ignored Files:
          reviewboard/templates/admin/authentication_settings.html
          reviewboard/templates/admin/scmtools/repository/change_form.html
      
      
    2. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'django_reset' imported but unused
      
    3. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'from settings_local import *' used; unable to detect undefined names
      
    4. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'PIPELINE_CSS' imported but unused
      
    5. reviewboard/settings.py (Diff revision 1)
       
       
      Show all issues
       'PIPELINE_JS' imported but unused
      
    6. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.6.x (01dbf07)