Fix the display of legacy screenshots.

Review Request #7843 — Created Jan. 4, 2016 and submitted

Information

Review Board
release-2.5.x

Reviewers

Legacy screenshots were broken due to some assumptions made in the new
image diff code. They checked for an attribute to be non-null, and if
that was the case, it would activate diffs, which then required certain
state not available for screenshots. Instead, we just want to check that
the attribute has a truthy value.

This is a pretty simple change, and results in both screenshots and
image file attachment (with and without diffs) working correctly once
again.

Tested with legacy screenshots, and image file attachments (with different
diff ranges, and without diffs).

reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/imageReviewableView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/imageReviewableView.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (e91cfeb)
Loading...