Return an SCMError for P4 errors.

Review Request #784 — Created March 24, 2009 and submitted

Information

Review Board SVN (deprecated)
trunk
710

Reviewers

Return an SCMError for P4 errors.

We've been returning a P4Error to represent Perforce errors, but
SCMTools really should return an SCMError so that we have one common
thing to catch and display. This change moves us over to using SCMError
instead.

We also now skip the first line only if it says "Perforce client error:" (we
might want to adjust this later) and only strip leading tabs from the
lines.

 
david
  1. Assuming that we know what the arguments to P4Error are supposed to be and are using them correctly, this looks fine.
  2. 
      
chipx86
chipx86
Review request changed
Change Summary:
Changed the code to return an SCMError instead of a P4Error.