Return an SCMError for P4 errors.
Review Request #784 — Created March 24, 2009 and submitted
Return an SCMError for P4 errors. We've been returning a P4Error to represent Perforce errors, but SCMTools really should return an SCMError so that we have one common thing to catch and display. This change moves us over to using SCMError instead. We also now skip the first line only if it says "Perforce client error:" (we might want to adjust this later) and only strip leading tabs from the lines.
- Summary:
-
Fix some bugs instantiating a P4Error.Return an SCMError for P4 errors.
- Description:
-
~ Fix some bugs instantiating a P4Error.
~ Return an SCMError for P4 errors.
~ P4Error these days takes 2 arguments, but we only provide 1. We also
~ leave off the first line when sometimes that line has useful info, and ~ we blindly strip off the first character of each line expecting a tab, ~ when sometimes there's actual data there. ~ We've been returning a P4Error to represent Perforce errors, but
~ SCMTools really should return an SCMError so that we have one common ~ thing to catch and display. This change moves us over to using SCMError ~ instead. ~ We now skip the first line only if it says "Perforce client error:" (we
~ We also now skip the first line only if it says "Perforce client error:" (we
might want to adjust this later) and only strip leading tabs from the lines.