Summary

Add some additional features to RB.CollectionView.

Review Request #7837 — Created Dec. 28, 2015 and submitted Jan. 4, 2016, 5:30 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change adds a few new things to RB.CollectionView:
- The view will properly respond when the collection is reset.
- The view will reorder DOM elements for sorted collections.
- The itemViewType can be passed in as an option at construction time, rather
than requiring CollectionView to be extended.
- A new itemViewOptions member allows options to be plumbed through to the
individual item views.

Testing Done

Used these features in another change (in Power Pack).

Issues

Description	From	Last Updated
Why not _onAdded, _onRemoved, etc?	chipx86	Dec. 30, 2015, 12:38 p.m.
Can we say what this does in more detail?	chipx86	Dec. 30, 2015, 12:38 p.m.
Blank line between these.	chipx86	Dec. 30, 2015, 12:44 p.m.
One-line summary.	chipx86	Dec. 30, 2015, 12:39 p.m.

```
Can we get unit tests for these?
```
reviewboard/static/rb/js/views/collectionView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Why not _onAdded, _onRemoved, etc?
```
reviewboard/static/rb/js/views/collectionView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we say what this does in more detail?
```
reviewboard/static/rb/js/views/collectionView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
1. david Dec. 30, 2015, 12:39 p.m.
  Why?
reviewboard/static/rb/js/views/collectionView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
One-line summary.
```

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/collectionView.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/collectionView.js

Diff:

Revision 2 (+59 -12)

Show changes

reviewboard/static/rb/js/views/collectionView.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/collectionView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/collectionView.js

Change Summary:

Add unit tests.

Diff:

Revision 3 (+113 -12)

Show changes

	reviewboard/static/rb/js/views/collectionView.js
	reviewboard/static/rb/js/views/tests/collectionViewTests.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/tests/collectionViewTests.js
    reviewboard/static/rb/js/views/collectionView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/tests/collectionViewTests.js
    reviewboard/static/rb/js/views/collectionView.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (356b8a3)