Fix errors with datagrid sorting with trailing commas in column lists.

Review Request #7836 — Created Dec. 28, 2015 and submitted

Information

Djblets
release-0.9.x

Reviewers

Bingbot's been causing some odd problems on our server, attempting to
access URLs with a sort column list that contains a trailing comma. This
meant that we had a blank entry in our parsed list of columns, which
crashed some very old code.

This might be a link we're generating somewhere, but we don't want to
crash in this case. We now ensure that the list from the client only
contains valid values.

Tested with a trailing comma. The page loaded, instead of crashing.

david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (3a64bb3)
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/datagrid/grids.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/datagrid/grids.py
    
    
  2. 
      
Loading...