Use Djblets' dynamic config pages for account pages
Review Request #7828 — Created Dec. 24, 2015 and submitted
| Information | |
|---|---|
| brennie | |
| Review Board | |
| release-2.6.x | |
|
|
|
| Reviewers | |
| reviewboard | |
Account pages now use the
ConfigPageRegistryand
DynamicConfigPageMixinfrom Djblets instead of using custom logic.
The external API has been kept the same, but it has been rewritten to
useRegistrymethods instead. Unit test logic has been updated to
check for the right exceptions.
- Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Swap these. |
 chipx86
|
|
|
Yielding here is going to be slower than just doing: return (AccountSettingsPage, APITokensPage, ...) We're already building the tuple for … |
chipx86
|
|
|
Maybe just set this directory below in AccountPage, and access it later as AccountPage.registry (similar to how we do ReviewRequest.objects)? |
chipx86
|
|
|
Blank line between these. |
chipx86
|
|
|
Are we aiming to deprecate these, or to keep them as the official API? I ask because it seems it'd … |
chipx86
|
|
|
I think you can just return iter(pages). |
chipx86
|
|
|
No need for parens. |
chipx86
|
|
|
We should use AccountPage.registry instead of pages. |
chipx86
|
|
|
I think you just changed the order of how things are shown on the user settings page. |
 david
|
-
-
-
reviewboard/accounts/pages.py (Diff revision 1) Yielding here is going to be slower than just doing:
return (AccountSettingsPage, APITokensPage, ...)We're already building the tuple for the
forloop, and generators have additional expense to them, often being slower for smaller lists of static things. -
reviewboard/accounts/pages.py (Diff revision 1) Maybe just set this directory below in
AccountPage, and access it later asAccountPage.registry(similar to how we doReviewRequest.objects)? -
-
reviewboard/accounts/pages.py (Diff revision 1) Are we aiming to deprecate these, or to keep them as the official API? I ask because it seems it'd be nice to exclusively use
AccountPage.registry.blah()for calls, but I know some of these wrap the registry calls in more detailed ways (logging exceptions, for instance).I wonder if we should move all the detail of these global functions into the registry subclass, mark all these as deprecated, and aim to use those exclusively.
-
-
-
reviewboard/accounts/tests.py (Diff revision 1) We should use
AccountPage.registryinstead ofpages.
-
Tool: Pyflakes Processed Files: reviewboard/accounts/tests.py reviewboard/accounts/pages.py Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/tests.py reviewboard/accounts/pages.py
-
Tool: Pyflakes Processed Files: reviewboard/accounts/tests.py reviewboard/accounts/pages.py Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/tests.py reviewboard/accounts/pages.py
-
-
reviewboard/accounts/pages.py (Diff revision 2) I think you just changed the order of how things are shown on the user settings page.
-
Tool: Pyflakes Processed Files: reviewboard/accounts/tests.py reviewboard/accounts/pages.py Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/tests.py reviewboard/accounts/pages.py