Show another column color if a review request was changed after a ShipIt

Review Request #7825 — Created Dec. 23, 2015 and discarded

misery
Review Board
release-2.5.x
reviewboard
If someone edit the review request it cannot be identified in overview
page that the ShipIt means only old review requests. So we show
the ShipIt column in another color if there is no ShipIt for the
latest review request.

We use this in our production review board.

Loading file attachments...

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
brennie
  1. Thanks for the patch. Could we see a screenshot of this?

  2. The gradient content should be refactored into a constant in defs.less.

  3. 
      
misery
misery
chipx86
  1. Thanks for the contribution. It's a very interesting addition, but I'm not ready to accept this just yet. The reason is that properly tracking whether a Ship It is still meaningful, and how many, is a larger problem that must be solved in a consistent way in the dashboard, reviews, API, and the tracking in the database. That problem needs to be solved still, and is being tracked on bug #2106.

    I'd like to keep this review request around in some form for inspiration/discussion. Maybe worth posting it on that bug? Could even roll this into an extension that adds this as an optional column.

    As far as the actual changes here, it's worth noting that the logic here adds 2 new queries per row, which will significantly slow down the dashboard. The appropriate queries would need to be rolled up into the initial database query in augment_queryset, gathering all the data needed to perform these computations.

    1. Thanks for your answer. :-)
      I will post my patch to the bug report, too. Maybe it is a quick work-around for that problem for someone until it has a better solution. By the way... I like the idea of Gerrit with configurable (-2, -1, 0, +1, +2) rates for every changeset. :-)

      Yeah, I was doubtful if the patch adds more queries. I will look into it to make it as an extension and lesser db queries if I have time.

  2. 
      
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/columns.py
    
    Ignored Files:
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/defs.less
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/columns.py
    
    Ignored Files:
        reviewboard/static/rb/css/ui/datagrids.less
        reviewboard/static/rb/css/defs.less
    
    
  2. 
      
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/columns.py
    
    Ignored Files:
        reviewboard/static/rb/css/ui/datagrids.less
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/columns.py
    
    Ignored Files:
        reviewboard/static/rb/css/ui/datagrids.less
    
    
  2. 
      
david
Review request changed

Status: Discarded

Loading...