Fix broken commit id of parent diff if it contains a valid ^ char

Review Request #7823 — Created Dec. 23, 2015 and submitted

Information

RBTools
release-0.7.x

Reviewers

Those '^' chars are valid to reference a relative revision.

Example:
hg log -r tip^1
hg log -r NODEID^5

If the reviewboard requests the old revision via hgweb it will fail
since hgweb does not support the relative revision syntax. So we
need to rewrite this relative node id to an absolute node id.

Also it will modify short and valid negative revision numbers to
full changeset node id as short revision numbers are local only.

hg log -r -1
hg log -r 123

Bugs closed: 3915


 
Description From Last Updated

Are there other symbolic reference formats that could cause the same issue? Should we always run this command no matter …

daviddavid

Now that this doesn't have a conditional to indicate what it's for, can we add a comment explaining what and …

daviddavid
david
  1. 
      
  2. rbtools/clients/mercurial.py (Diff revision 1)
     
     
    Show all issues

    Are there other symbolic reference formats that could cause the same issue? Should we always run this command no matter what?

    1. Only local revision numbers (numbers only) and negative numbers as a relative node id. I removed the if clause....

  3. 
      
misery
misery
david
  1. 
      
  2. rbtools/clients/mercurial.py (Diff revision 2)
     
     
    Show all issues

    Now that this doesn't have a conditional to indicate what it's for, can we add a comment explaining what and why?

  3. 
      
misery
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/mercurial.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/clients/mercurial.py
    
    
  2. 
      
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/mercurial.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/clients/mercurial.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/mercurial.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/mercurial.py
    
    
  2. 
      
misery
  1. Ping! Anything to do here? :-)

  2. 
      
david
  1. Ship It!
  2. 
      
misery
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (d66f628)
Loading...