Summary

Fix broken commit id of parent diff if it contains a valid ^ char

Review Request #7823 — Created Dec. 23, 2015 and submitted Jan. 20, 2016, 2:06 p.m.

Information

Owner

misery

Repository

RBTools

Branch

release-0.7.x

Bugs

3915

Depends On

Blocks

7824

Reviewers

Groups

rbtools

People

Description

Those '^' chars are valid to reference a relative revision.

Example:
hg log -r tip^1
hg log -r NODEID^5

If the reviewboard requests the old revision via hgweb it will fail
since hgweb does not support the relative revision syntax. So we
need to rewrite this relative node id to an absolute node id.

Also it will modify short and valid negative revision numbers to
full changeset node id as short revision numbers are local only.

hg log -r -1
hg log -r 123

Bugs closed: 3915

Testing Done

Issues

Description	From	Last Updated
Are there other symbolic reference formats that could cause the same issue? Should we always run this command no matter …	david	Dec. 28, 2015, 9:29 a.m.
Now that this doesn't have a conditional to indicate what it's for, can we add a comment explaining what and …	david	Dec. 28, 2015, 3:33 p.m.

rbtools/clients/mercurial.py (Diff revision 1)

The issue has been resolved. Show all issues

Are there other symbolic reference formats that could cause the same issue? Should we always run this command no matter what?

misery Dec. 28, 2015, 9:30 a.m.

Only local revision numbers (numbers only) and negative numbers as a relative node id. I removed the if clause....

Diff:

Revision 2 (+4)

Show changes

rbtools/clients/mercurial.py

Description:: Those '^' chars are valid to reference a relative revision.

Example:
hg log -r tip^1
hg log -r NODEID^5

If the reviewboard requests the old revision via hgweb it will fail
since hgweb does not support the relative revision syntax. So we
~ need to rewrite this relative node id to an absolute note id.
~ need to rewrite this relative node id to an absolute node id.
+
+
Also it will modify short and valid negative revision numbers to
+ full changeset node id as short revision numbers are local only.
+
+
hg log -r -1
+ hg log -r 123

Bugs closed: 3915

rbtools/clients/mercurial.py (Diff revision 2)

The issue has been resolved. Show all issues

Now that this doesn't have a conditional to indicate what it's for, can we add a comment explaining what and why?

Diff:

Revision 3 (+7)

Show changes

rbtools/clients/mercurial.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/mercurial.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/mercurial.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/mercurial.py



Tool: Pyflakes
Processed Files:
    rbtools/clients/mercurial.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/mercurial.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/mercurial.py

```
Ping! Anything to do here? :-)
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.7.x (d66f628)

		Those '^' chars are valid to reference a relative revision.

		Example:
		hg log -r tip^1
		hg log -r NODEID^5

		If the reviewboard requests the old revision via hgweb it will fail
		since hgweb does not support the relative revision syntax. So we
~		need to rewrite this relative node id to an absolute note id.
	~	need to rewrite this relative node id to an absolute node id.
	+
	+	Also it will modify short and valid negative revision numbers to
	+	full changeset node id as short revision numbers are local only.
	+
	+	hg log -r -1
	+	hg log -r 123

		Bugs closed: 3915