Prefer deque over inserting to start of list

 






 

 


  Review Request #7820
  —
  Created Dec. 22, 2015 and submitted 

 


















 

  

   Information

  





 
 

  brennie
 









 
 

  RBTools
 









 
 

  release-0.7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
Prepending to a python list is inefficient (according to the

python docs, list.insert(0, v) is O(n)) and using a deque is

superior for performance (deque.appendleft(v) is O(1)).

 








  


 
 

  
Testing done:

- Ran unit tests.

 







 









 





  








 









 






  

 








 














 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Tool: Pyflakes
Processed Files:
    rbtools/clients/clearcase.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/clearcase.py


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




brennie




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-0.7.x (e716174)





 


 










  

 









     

    

   

  

  

   
   Loading...