Change the call to server.get_repositories to filter on the server side based on the VCS type inside the clients.

Review Request #7818 — Created Dec. 21, 2015 and discarded

solarmist
RBTools
master
rbtools

Change the call to server.get_repositories to filter on the server side based on the VCS type inside the clients.

We have over 3000 git repos in our instance (but significantly less SVN repos) and have people working overseas from our RB instance causing over 100 network call roundtrips. This reduces those extra calls to the single digits.

This patch is based on Line 128 of.
https://github.com/reviewboard/reviewboard/blob/master/reviewboard/webapi/resources/repository.py

This is a patch forward for the latest version of RBTools. It is based on the work done in
https://reviews.reviewboard.org/r/7817/.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/clients/svn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/clients/svn.py
    
    
  2. rbtools/clients/svn.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (82 > 79 characters)
    
  3. 
      
solarmist
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/clients/svn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/clients/svn.py
    
    
  2. 
      
brennie
  1. Hi! Sorry, but the way things work, your previous patch would be (if shipped) landed on release-0.7.x. During the merge from 0.7.x into master, we'd hit a merge conflict and it would be fixed in the merge. This patch isn't necessary.

    1. That's fine. I'll close this review then.

  2. 
      
solarmist
Review request changed

Status: Discarded

Change Summary:

It will be merged from the 0.7.x branch.

Loading...