Summary

Change the call to server.get_repositories to filter on the server side based on the VCS type inside the clients.

Review Request #7818 — Created Dec. 21, 2015 and discarded Dec. 21, 2015, 9:07 p.m.

Information

Owner

solarmist

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Change the call to server.get_repositories to filter on the server side based on the VCS type inside the clients.

We have over 3000 git repos in our instance (but significantly less SVN repos) and have people working overseas from our RB instance causing over 100 network call roundtrips. This reduces those extra calls to the single digits.

This patch is based on Line 128 of.
https://github.com/reviewboard/reviewboard/blob/master/reviewboard/webapi/resources/repository.py

Testing Done

This is a patch forward for the latest version of RBTools. It is based on the work done in
https://reviews.reviewboard.org/r/7817/.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Dec. 21, 2015, 11:25 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/clients/svn.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/clients/svn.py

rbtools/clients/svn.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

Change Summary:

Fixed line length

Commit:

558044b15053fb30783b6798306a0ebacfdebe77

9e48a1264875d5e612c47768af4783562aa6579f

Diff:

Revision 2 (+3 -7)

Show changes

	rbtools/clients/clearcase.py
	rbtools/clients/svn.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/clients/svn.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/clearcase.py
    rbtools/clients/svn.py

Hi! Sorry, but the way things work, your previous patch would be (if shipped) landed on release-0.7.x. During the merge from 0.7.x into master, we'd hit a merge conflict and it would be fixed in the merge. This patch isn't necessary.

solarmist Dec. 21, 2015, 9:07 p.m.

That's fine. I'll close this review then.

Status:: Discarded
Change Summary:: It will be merged from the 0.7.x branch.

rbtools/clients/svn.py (Diff revision 1)