Make get_repositories filter on the server side

Review Request #7817 — Created Dec. 21, 2015 and submitted

solarmist
RBTools
release-0.7.x
45585cc...
rbtools

Change the call to server.get_repositories to filter on the server side
based on the VCS type inside the clients.

We have over 3000 git repos in our instance (but significantly less SVN
repos) and have people working overseas from our RB instance causing
over 100 network call roundtrips. This reduces those extra calls to
the single digits.

I've tested manually by digging into the Rest API, code review, and
manual testing at LinkedIn. We have forked rbtools internally to deploy
this patch also.

Ran Unit tests:
Ran 167 tests in 39.185s
OK (SKIP=28)

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/clients/svn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/clients/svn.py
    
    
  2. 
      
brennie
  1. Thanks for the patch! This looks good, but I have a few nitpicks for you.

    Also could you please format your summary to be <= 50 chars long and your description + testing done to be wrapped at 72 chars? Your summary + description will end up as the commit message and git prefers those limits for the message.

    Could you also verify the unit tests passed with this change?

    Thanks again!

  2. rbtools/clients/clearcase.py (Diff revision 1)
     
     
     

    Some of the second line will fit on the first line.

  3. rbtools/clients/svn.py (Diff revision 1)
     
     
     

    Some of the second line will fit on the first line.

  4. 
      
solarmist
solarmist
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/clients/svn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/clearcase.py
        rbtools/clients/svn.py
    
    
  2. 
      
brennie
  1. Please don't include the entire output of the tests in the testing done. "Ran unit tests" is sufficient.

  2. 
      
solarmist
brennie
  1. Ship It!
  2. 
      
solarmist
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (6a4c068)
Loading...