Do not loose commit history when specifying summary manually.

Review Request #7806 — Created Dec. 14, 2015 and discarded

Information

RBTools
master

Reviewers

When submitting multiple commits with one request on ReviewBoard RBTools sets the last commit message as the summary. But, when using the option "--summary” the last commit message is lost and is not written anywhere.

Proposed change stores all commit messages in the description field when both --summary 'text’ and --guess-description options are set.

When a request is send without the "--summary” option the last commit message is written in the summary, as usual.
When a request is send with the "--summary” option the last commit message is written in the description.
When a request is one commit without option "--summary” last commit message is written in the summary, as usual.
When a request comprises one commit then all works as usual.

Description From Last Updated

Col: 80 E501 line too long (86 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (119 > 79 characters)

reviewbotreviewbot

Col: 27 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 80 E501 line too long (86 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (121 > 79 characters)

reviewbotreviewbot

Col: 122 W291 trailing whitespace

reviewbotreviewbot

Col: 80 E501 line too long (86 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (121 > 79 characters)

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
    
    
  2. rbtools/commands/post.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (86 > 79 characters)
    
  3. rbtools/commands/post.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (119 > 79 characters)
    
  4. rbtools/commands/post.py (Diff revision 1)
     
     
    Col: 27
     E111 indentation is not a multiple of four
    
  5. rbtools/commands/post.py (Diff revision 1)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  6. 
      
AL
AL
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
    
    
  2. rbtools/commands/post.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (86 > 79 characters)
    
  3. rbtools/commands/post.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (121 > 79 characters)
    
  4. rbtools/commands/post.py (Diff revision 2)
     
     
    Col: 122
     W291 trailing whitespace
    
  5. 
      
AL
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
    
    
  2. rbtools/commands/post.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (86 > 79 characters)
    
  3. rbtools/commands/post.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (121 > 79 characters)
    
  4. 
      
david
  1. Discarding in favor of /r/8092

  2. 
      
AL
Review request changed

Status: Discarded

Loading...