Add the "mailing list only" field to the Group admin.

Review Request #7802 — Created Dec. 10, 2015 and submitted

Information

Review Board
release-2.5.x

Reviewers

We shipped a feature that allowed making groups notify both the users and the
mailing list, but we never exposed it in the admin. This change does that, and
fixes a typo in the help text.

While I was here I also made the "users" field be a raw ID field, so that the
group admin page wouldn't take so long to load.

Looked at the group admin page and saw the expected UI.

Description From Last Updated

Do we still need filter_horizontal if its in raw_id_fields?

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/admin.py
        reviewboard/reviews/models/group.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/admin.py
        reviewboard/reviews/models/group.py
    
    
  2. 
      
brennie
  1. Looks good to me, save for one small question about the change:

  2. reviewboard/reviews/admin.py (Diff revision 1)
     
     
     
    Show all issues

    Do we still need filter_horizontal if its in raw_id_fields?

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (f34d5e4)
Loading...