Summary

Add the "mailing list only" field to the Group admin.

Review Request #7802 — Created Dec. 10, 2015 and submitted Dec. 11, 2015, 5:27 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We shipped a feature that allowed making groups notify both the users and the
mailing list, but we never exposed it in the admin. This change does that, and
fixes a typo in the help text.

While I was here I also made the "users" field be a raw ID field, so that the
group admin page wouldn't take so long to load.

Testing Done

Looked at the group admin page and saw the expected UI.

Issues

Description	From	Last Updated
Do we still need filter_horizontal if its in raw_id_fields?	brennie	Dec. 11, 2015, 5:26 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/admin.py
    reviewboard/reviews/models/group.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/admin.py
    reviewboard/reviews/models/group.py

Ship it!

Looks good to me, save for one small question about the change:

reviewboard/reviews/admin.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Do we still need filter_horizontal if its in raw_id_fields?
```
1. david Dec. 11, 2015, 5:26 p.m.
  Nope!

Status:: Completed
Change Summary:: Pushed to release-2.5.x (f34d5e4)