Summary

This was first encountered on a perforce changelist with a deleted symlink. The exact exception:

Review Request #7801 — Created Dec. 10, 2015 and submitted Dec. 10, 2015, 4:02 p.m.

Information

Owner

akiskall

Repository

RBTools

Branch

master

Bugs

4037

Depends On

Reviewers

Groups

rbtools

People

Description

Generating diff for pending changeset 205103
Traceback (most recent call last):
  File "/usr/lib/python2.7/logging/__init__.py", line 859, in emit
    msg = self.format(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 732, in format
    return fmt.format(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 471, in format
    record.message = record.getMessage()
  File "/usr/lib/python2.7/logging/__init__.py", line 335, in getMessage
    msg = msg % self.args
TypeError: not enough arguments for format string
Logged from file perforce.py, line 620

The fix is trivial. One more missing parameter is added in logging.

Testing Done

Tested with the same changelist locally. Now the warning is correctly shown:

Update existing Review Request...
Generating diff for pending changeset 205103
WARNING: Skipping file //depot/fusion/main/os/asm/etc/systemd/system/runlevel3.target.wants/vmwaretools.service#1: "//depot/fusion/main/os/asm/etc/systemd/system/runlevel3.target.wants/vmwaretools.service#1" is a symlink
Review request #51441 posted.

http://reviews.bytemobile.com/r/51441/
http://reviews.bytemobile.com/r/51441/diff/

Issues

Description	From	Last Updated
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Dec. 10, 2015, 6:03 a.m.
Col: 25 E128 continuation line under-indented for visual indent	reviewbot	Dec. 10, 2015, 6:13 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/perforce.py

rbtools/clients/perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```

Change Summary:

Fixed the long line issue.

Diff:

Revision 2 (+2 -1)

Show changes

rbtools/clients/perforce.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/perforce.py

rbtools/clients/perforce.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 25
 E128 continuation line under-indented for visual indent
```

Change Summary:

Fixed E128 continuation line under-indented for visual indent

Diff:

Revision 3 (+3 -1)

Show changes

rbtools/clients/perforce.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/perforce.py

Hi! This looks good, however can you rewrite the summary? When this lands, the summary will become the first line of the commit message (and the description will become the rest of the body).

Thanks!

akiskall Dec. 11, 2015, 12:45 a.m.

Sorry for that. This is my first contribution in general and i didn't know how the exact process works. I can see however that the actual commit in both master and release-0.7.x branches by davidt already has a proper summary and description so i think we are good! Thank you!

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (0279699)

rbtools/clients/perforce.py (Diff revision 1)

rbtools/clients/perforce.py (Diff revision 2)