This was first encountered on a perforce changelist with a deleted symlink. The exact exception:

Review Request #7801 — Created Dec. 10, 2015 and submitted

Information

RBTools
master

Reviewers

Generating diff for pending changeset 205103
Traceback (most recent call last):
  File "/usr/lib/python2.7/logging/__init__.py", line 859, in emit
    msg = self.format(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 732, in format
    return fmt.format(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 471, in format
    record.message = record.getMessage()
  File "/usr/lib/python2.7/logging/__init__.py", line 335, in getMessage
    msg = msg % self.args
TypeError: not enough arguments for format string
Logged from file perforce.py, line 620

The fix is trivial. One more missing parameter is added in logging.

Tested with the same changelist locally. Now the warning is correctly shown:

Update existing Review Request...
Generating diff for pending changeset 205103
WARNING: Skipping file //depot/fusion/main/os/asm/etc/systemd/system/runlevel3.target.wants/vmwaretools.service#1: "//depot/fusion/main/os/asm/etc/systemd/system/runlevel3.target.wants/vmwaretools.service#1" is a symlink
Review request #51441 posted.

http://reviews.bytemobile.com/r/51441/
http://reviews.bytemobile.com/r/51441/diff/

Description From Last Updated

Col: 80 E501 line too long (92 > 79 characters)

reviewbotreviewbot

Col: 25 E128 continuation line under-indented for visual indent

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/perforce.py
    
    
  2. rbtools/clients/perforce.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (92 > 79 characters)
    
  3. 
      
AK
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/perforce.py
    
    
  2. rbtools/clients/perforce.py (Diff revision 2)
     
     
    Show all issues
    Col: 25
     E128 continuation line under-indented for visual indent
    
  3. 
      
AK
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/perforce.py
    
    
  2. 
      
brennie
  1. Hi! This looks good, however can you rewrite the summary? When this lands, the summary will become the first line of the commit message (and the description will become the rest of the body).

    Thanks!

    1. Sorry for that. This is my first contribution in general and i didn't know how the exact process works. I can see however that the actual commit in both master and release-0.7.x branches by davidt already has a proper summary and description so i think we are good! Thank you!

  2. 
      
david
  1. Ship It!
  2. 
      
AK
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.7.x (0279699)