-
-
/trunk/reviewboard/reviews/datagrids.py (Diff revision 1) Have you tested what happens if the number of reviewers is greater than num_shipit? Looks like in that case you don't get the green checkmark, but something like 5/3. Is that what you want?
Changes "ship-it!" status to "number of ship it"
Review Request #780 — Created March 24, 2009 and discarded
Information | |
---|---|
loki980 | |
Review Board SVN (deprecated) | |
919 | |
Reviewers | |
reviewboard | |
If no individual people are assigned to the review, "Ship It!" column function remains unchanged. If individual people are assigned to the review, it will return the fraction of "Ship It!" statuses achieved. IE "1/3" If 100% say ship it, the green checkmark image is displayed.
Works for me in all but one case. If a user submits 2 "ship it" reviews, it counts those reviews twice. How can you perform a filter, indicating "user" must be unique? (Sorry, rather new to Python here.)
KI
LO
Change Summary:
Addresses the two issues mentioned above. This certainly is not a pretty way to accomplish the task. However, I don't know how else to run a filter based upon a set/list of allowable values. I welcome anyone else's ideas if they can implement it more cleanly.
Diff: |
Revision 2 (+22 -4) |
---|