Summary

Switch Review Board to use Djblets' markdown_escape everywhere

Review Request #7790 — Created Dec. 3, 2015 and submitted Dec. 12, 2015, 12:20 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Previously reviewboard.reviews.markdown_utils.markdown_escape became
deprecated. However, several methods in the markdown_utils module
still referred to the old, deprecated markdown_escape. This updates
all usages to use Djblet's version of markdown_escape.

Testing Done

Ran unit tests.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/markdown_utils.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/markdown_utils.py

I wasn't sure from the summary until I read into this more. Can you change the summary to be more self-descriptive, like "Swithc Review Board to the new markdown_escape in Djblets" ?

Summary:

-	Use djblets.markdown.markdown_escape
+	Switch Review Board to use Djblet's markdown_escape everywhere

Ship it!

The package name is "Djblets", so the possessive should be "Djblets'"

Summary:

-	Switch Review Board to use Djblet's markdown_escape everywhere
+	Switch Review Board to use Djblets' markdown_escape everywhere

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (ac3abb3)