Tool: Pyflakes
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py

Col: 13
 E122 continuation line missing indentation or outdented

Col: 13
 E122 continuation line missing indentation or outdented

Tool: PEP8 Style Checker
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py



Tool: Pyflakes
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py

I think I'd like more explanation about what "Prefix a Q expression" means. Can you give an example?

Just calling six.binary_type will explode if there's any non-ascii characters in there. Maybe that's what you want, but otherwise, perhaps use .encode('utf-8')?

It's pretty weird to see the u'' in there. Is that just something funky with Q.__str__?

Tool: PEP8 Style Checker
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py



Tool: Pyflakes
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py



Tool: Pyflakes
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py

How about explaining that:

B.objects.filter(prefix_q(Q(field='value'), 'a'))


is the same as:

B.objects.filter(Q(a__field='value'))

Tool: Pyflakes
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py

"Return," not "Get."
I don't think it's worth using Sphinx references for things like "None" in a summary.

For these, maybe:
:py;meth:`Manager.get <django.db.models.manager.Manager.get>

""" is indented too far.

I feel like this doesn't describe this well enough. The example does, but I'd like to see a bit more about how this is useful.
It should also go into the cloning behavior and defaults.

This is backwards. It's title <reference>.

This should be:
Example:
    .. code-block:: python

       <example here>

In other files, this is also after Args and Returns.

Sentence casing.

Sentence casing.

Are you sure about this reference? The Django docs are showing it under django.db.models.Q.

I don't know that :py:data: is really appropriate for things like True, False, or None. It's really intended for module-level data, with the implication being the current module. Does it result in actual links to the Python docs?

It's not clear to me, reading the unit tests and the code, whether all these cases are covered. Probably because parts involve internal Q knowledge, but I want to make sure we have 100% coverage of this.

Any reason we don't just use isinstance? Generally, it's nice not to restrict to a specific base type, so long as the thing coming in behaves like the expected type.
Also, this shouldn't be an assertion, it should raise an exception if it's not a valid type. Assertions are for internal code that should always be correct, and are just to verify something isn't screwed up (like an internal function calling another internal function with some certain state).

Is this needed? Are we aware of cases where it must be a byte string? I thought Unicode strings were fine here.
If this is indeed required, we need to have a unit test for it.

Unit test suite docstrings are in the form of: "Unit tests for module.path.to.thing." Also, trailing period.

The docstrings should all mention prefix_q.

Tool: PEP8 Style Checker
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py



Tool: Pyflakes
Processed Files:
    djblets/db/query.py
    djblets/db/tests/test_query.py

Should be "Return a model instance"