Defining a mode for imageAttachmentView

Review Request #7772 — Created Nov. 15, 2015 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

When rendering the image review view, the div class for the image itself in imageAttachmentView mode currently has name image-diff-null. This is because the base class BaseImageView initializes mode to null but the subclass imageAttachmentView does not define a proper name for it. This can potentially confuse devs, or at the very least, it gives the impression that the class was not extended properly.

This patch fixes the problem by setting the mode to attachment so that the div class will be image-diff-attachment rather than image-diff-null.

Used Inspect Element tool on the browser to ensure that the div class now reads image-diff-attachment.

    Loading...