Defining a mode for imageAttachmentView
Review Request #7772 — Created Nov. 15, 2015 and submitted — Latest diff uploaded
When rendering the image review view, the div class for the image itself in imageAttachmentView mode currently has name
image-diff-null
. This is because the base classBaseImageView
initializesmode
tonull
but the subclassimageAttachmentView
does not define a proper name for it. This can potentially confuse devs, or at the very least, it gives the impression that the class was not extended properly.This patch fixes the problem by setting the
mode
toattachment
so that the div class will beimage-diff-attachment
rather thanimage-diff-null
.
Used Inspect Element tool on the browser to ensure that the div class now reads
image-diff-attachment
.