Enables the option for color to be displayed Open Issues and Ship It!
Review Request #7770 — Created Nov. 14, 2015 and discarded
RBT Status currently does not have the option for color to be displayed for Open Issues and Ship It! reviews.
I am adding color to make Open Issues yellow and Ship It! reviews green. This is a dependent feature of the RBTools color output.
I ran the ./reviewboard/manage.py test and they passed. I ran rbt status, and it displays yellow for Open Issues and green for Ship it!
Description | From | Last Updated |
---|---|---|
I believe this should be categorized with the above import statements in alphabetical order. Most the files in rbtools I … |
JW jwu | |
Needs a space at end of line. |
brennie | |
Needs a ,. |
brennie | |
Needs a ,. |
brennie | |
This isn't the approach you're going to want to use. You're going to want to look at https://pypi.python.org/pypi/colorama and use, … |
brennie | |
See other comment. |
brennie | |
Col: 80 E501 line too long (84 > 79 characters) |
reviewbot | |
Put the ] on the next line. This should have a , at the end. |
brennie | |
Col: 33 E127 continuation line over-indented for visual indent |
reviewbot | |
Col: 33 E127 continuation line over-indented for visual indent |
reviewbot | |
Don't need this here. |
brennie | |
Remove this. |
brennie | |
You need to do add Fore.RESET to the end of these strings. |
brennie | |
This should be in your other patch. You committed on the wrong branch. Ping me early next week and we … |
brennie | |
Undo this change. |
brennie | |
Undo this |
brennie | |
This shouldn't be in this patch. |
brennie | |
This shouldn't be in your patch. Make sure you are posting correctly with rbt post -u branch1..branch2 |
brennie | |
Undo this. |
brennie | |
Remove this. |
brennie | |
Can you format this as: status = ('%sOpen Issues (%s)%s' % (Fore.YELLOW, request.issue_open_count, Fore.RESET)) with appropriate wrapping? |
brennie | |
Likewise here. |
brennie | |
'ColoredFormatter' imported but unused |
reviewbot | |
This should be renamed to status_width and the result is no longer always len(status). Becuase status contains control codes, which … |
brennie |
- Testing Done:
-
+ None, want to see if I'm on the right track
- Groups:
-
It appears you ahve posted two changes at once.
Can you run
rbt post -r 7770 rbtcolors..dev/colorize-status
(or whatever your branch names are).That way you will only have the latter code in this patch.
You should also mark this as depending on your previous work.
-
-
-
-
- Description:
-
RBT Status currently does not have the option for color to be displayed for Open Issues and Ship It! reviews.
~ I am adding color to make Open Issues yellow and Ship It! reviews green. ~ I am adding color to make Open Issues yellow and Ship It! reviews green. This is a dependent feature of the RBTools color output. - Testing Done:
-
~ None, want to see if I'm on the right track
~ I ran the ./reviewboard/manage.py test and they passed, but I received an error when I ran the rbt status command. I've included a picture of what it looks like.
- Diff:
-
Revision 2 (+26 -10)
- Added Files:
-
Tool: Pyflakes Processed Files: rbtools/commands/status.py setup.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py setup.py rbtools/commands/__init__.py
-
-
- Testing Done:
-
~ I ran the ./reviewboard/manage.py test and they passed, but I received an error when I ran the rbt status command. I've included a picture of what it looks like.
~ I ran the ./reviewboard/manage.py test and they passed. I ran rbt status, and it displays yellow for Open Issues.
- Diff:
-
Revision 3 (+26 -10)
- Added Files:
-
Tool: Pyflakes Processed Files: rbtools/commands/status.py setup.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py setup.py rbtools/commands/__init__.py
-
Tool: Pyflakes Processed Files: rbtools/commands/status.py setup.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py setup.py rbtools/commands/__init__.py
-
Tool: Pyflakes Processed Files: rbtools/commands/status.py setup.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py setup.py rbtools/commands/__init__.py
-
Tool: Pyflakes Processed Files: rbtools/commands/status.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py rbtools/commands/__init__.py
-
Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py rbtools/commands/__init__.py Tool: Pyflakes Processed Files: rbtools/commands/status.py rbtools/commands/__init__.py
- Summary:
-
Enables the option for color to be displayed Open Issues and Ship It! [WIP]Enables the option for color to be displayed Open Issues and Ship It!
- Testing Done:
-
~ I ran the ./reviewboard/manage.py test and they passed. I ran rbt status, and it displays yellow for Open Issues.
~ I ran the ./reviewboard/manage.py test and they passed. I ran rbt status, and it displays yellow for Open Issues and green for Ship it!
-
Tool: Pyflakes Processed Files: rbtools/commands/status.py rbtools/commands/__init__.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py rbtools/commands/__init__.py
-
This regresses the table-formatted output:
(rb)~/W/R/s/reviewboard (dev/refactor-registry/fields) $ rbt status ===================================================================================== Status Review Request ===================================================================================== Ship It! (1) r/7787 - Do not attempt to render uninstantiated fields Pending r/7786 - Use registries for hosting services Pending r/7785 - Use registries for authentication backends
The
r/7787
bit should be under the Review Request column. -
This should be renamed to
status_width
and the result is no longer alwayslen(status)
.Becuase
status
contains control codes, which are zero-width characters, this will end up calculating the wrong column width. You will have to calculate the width in the cases above and pass it through here.If you do rename this
status_width
, you'll have to update whatever takes in these to print the table to expectstatus_width
instead ofstatus_len
.