Add Help Menu

Review Request #7760 — Created Nov. 7, 2015 and updated

kvdgulik
Review Board
master
reviewboard

Created a help menu that replaces the old support menu. This new help menu allows pages to offer page specific help. The help menu also provides a key binding's reminder modal that is accessable by the '?' keyboard shortcut. This included adding the library QuestionMark.js(http://impressivewebs.github.io/QuestionMark.js/) to reviewboard, and making sure that the modal created using this library only appeared when a page has key binding content.

This change has been tested on Chrome, Firefox, Safari and IE.

Testing involved making sure that the links in the menu led where expected, and that the menu correctly displayed page specific content. It also invloved making sure that the key-bindings modal was accessable via the keyboard shortcut '?' in screens with keyboard shortcuts, and otherwise was not accessable.

Loading file attachments...

Description From Last Updated

Trailing whitespace.

brenniebrennie

Should only be indented one space relative to <ul>.

brenniebrennie

Is this the SHA of QuestionMark.js or your commit? We want to include the commit ID of QuestionMark.js that you ...

brenniebrennie

Trailing whitespace.

brenniebrennie

Trailing whitespace.

brenniebrennie

Undo this.

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
KV
KV
KV
KV
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/templates/base.html (Diff revision 2)
     
     

    Trailing whitespace.

  3. Should only be indented one space relative to <ul>.

  4. 
      
KV
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
KV
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
KV
KV
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/static/lib/js/README.questionmarkjs
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/static/lib/js/README.questionmarkjs
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
brennie
  1. 
      
  2. Is this the SHA of QuestionMark.js or your commit? We want to include the commit ID of QuestionMark.js that you used.

    1. This is the SHA for my commit. I'm not sure what the commit for QuestionMark.js would be, as I downloaded the zip file for the project from their webpage.

  3. Trailing whitespace.

  4. Trailing whitespace.

  5. Undo this.

  6. 
      
KV
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/static/lib/js/README.questionmarkjs
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/static/lib/js/README.questionmarkjs
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
KV
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/static/lib/js/README.questionmarkjs
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/static/lib/js/README.questionmarkjs
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
KV
KV
Review request changed
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/static/lib/js/README.questionmarkjs
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/question.mark.js
        reviewboard/static/lib/js/README.questionmarkjs
        reviewboard/templates/base.html
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/static/rb/css/pages/base.less
        reviewboard/templates/base/helpmodal.html
        reviewboard/static/lib/css/question.mark.css
        reviewboard/templates/reviews/reviewable_base.html
    
    
  2. 
      
Loading...