Add Help Menu
Review Request #7760 — Created Nov. 7, 2015 and discarded
Created a help menu that replaces the old support menu. This new help menu allows pages to offer page specific help. The help menu also provides a key binding's reminder modal that is accessable by the '?' keyboard shortcut. This included adding the library QuestionMark.js(http://impressivewebs.github.io/QuestionMark.js/) to reviewboard, and making sure that the modal created using this library only appeared when a page has key binding content.
This change has been tested on Chrome, Firefox, Safari and IE.
Testing involved making sure that the links in the menu led where expected, and that the menu correctly displayed page specific content. It also invloved making sure that the key-bindings modal was accessable via the keyboard shortcut '?' in screens with keyboard shortcuts, and otherwise was not accessable.
| Description | From | Last Updated |
|---|---|---|
|
Trailing whitespace. |
 brennie
|
|
|
Should only be indented one space relative to <ul>. |
brennie
|
|
|
Is this the SHA of QuestionMark.js or your commit? We want to include the commit ID of QuestionMark.js that you … |
brennie
|
|
|
Trailing whitespace. |
brennie
|
|
|
Trailing whitespace. |
brennie
|
|
|
Undo this. |
brennie
|
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html
KV
- Diff:
-
Revision 3 (+410 -2)
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html
KV
- Diff:
-
Revision 4 (+410 -2)
-
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html
KV
- Description:
-
This task involves:
1. COMPLETE: changing the support menu to a help menu that allows the items to change depending on what page it is accessed from.
~ 2. IN PROGRESS: Enable Question Mark Js in the project and make it accessable via the 'Key Bindings' menu item
~ 2. COMPLETE: Enable Question Mark Js in the project and make it accessable via the 'Key Bindings' menu item
~ 3. NOT STARTED: Modifying the question mark js modal to allow us to use it for page specific content and a variety of content other then keybindings (ex. Markdown Reminders Modal).
~ 3. COMPLETE Modifying the question mark js modal to allow us to use it for page specific content and a variety of content other then keybindings (ex. Markdown Reminders Modal).
~ 4. NOT STARTED: Creating a 'Markdown Reminders' Modal accessed from the help menu
~ 4. IN PROGRESS: Creating a 'Markdown Reminders' Modal accessed from the help menu
KV
- Diff:
-
Revision 5 (+461 -2)
-
Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/static/lib/js/README.questionmarkjs reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/static/lib/js/README.questionmarkjs reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html
KV
- Diff:
-
Revision 6 (+461 -1)
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/static/lib/js/README.questionmarkjs reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/static/lib/js/README.questionmarkjs reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html
KV
- Diff:
-
Revision 7 (+505 -1)
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/static/lib/js/README.questionmarkjs reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/static/lib/js/README.questionmarkjs reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html
KV
- Summary:
-
WIP: Add Help MenuAdd Help Menu
- Description:
-
~ This task involves:
~ Created a help menu that replaces the old support menu. This new help menu allows pages to offer page specific help. The help menu also provides a key binding's reminder modal that is accessable by the '?' keyboard shortcut. This included adding the library QuestionMark.js(http://impressivewebs.github.io/QuestionMark.js/) to reviewboard, and making sure that the modal created using this library only appeared when a page has key binding content.
- - 1. COMPLETE: changing the support menu to a help menu that allows the items to change depending on what page it is accessed from.
- - 2. COMPLETE: Enable Question Mark Js in the project and make it accessable via the 'Key Bindings' menu item
- - 3. COMPLETE Modifying the question mark js modal to allow us to use it for page specific content and a variety of content other then keybindings (ex. Markdown Reminders Modal).
- - 4. IN PROGRESS: Creating a 'Markdown Reminders' Modal accessed from the help menu
- Testing Done:
-
+ This change has been tested on Chrome, Firefox, Safari and IE.
+ + Testing involved making sure that the links in the menu led where expected, and that the menu correctly displayed page specific content. It also invloved making sure that the key-bindings modal was accessable via the keyboard shortcut '?' in screens with keyboard shortcuts, and otherwise was not accessable.
KV
- Diff:
-
Revision 8 (+512 -1)
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/static/lib/js/README.questionmarkjs reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/static/lib/js/README.questionmarkjs reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/templates/base/helpmodal.html reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/static/lib/js/question.mark.js reviewboard/templates/base.html reviewboard/templates/base/_nav_support_menu.html reviewboard/static/rb/css/pages/base.less reviewboard/static/lib/css/question.mark.css reviewboard/templates/reviews/reviewable_base.html