Use the correct resource to serialize comments in the review_reply webhook

Review Request #7755 — Created Nov. 4, 2015 and submitted

Information

Review Board
release-2.5.x

Reviewers

My fix for the review_reply_published webhook event fixed the main
serialization, but the comments were still using the wrong resources. This
change fixes those.

Ran unit tests.

Description From Last Updated

This and serialize_reply do the same thing, except on different resources. Can we refactor this to take the review_key (as …

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/notifications/webhooks.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/notifications/webhooks.py
    
    
  2. 
      
brennie
  1. 
      
  2. reviewboard/notifications/webhooks.py (Diff revision 1)
     
     

    This and serialize_reply do the same thing, except on different resources. Can we refactor this to take the review_key (as before), as well as the resource to use for serialization?

    1. So this is what I was doing, but it would mean passing in all four resources now, which seemed like so much that having one method wasn't worth the trouble.

  3. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (8e9d4e6)
Loading...