Summary

Use the correct resource to serialize comments in the review_reply webhook

Review Request #7755 — Created Nov. 4, 2015 and submitted Nov. 6, 2015, 12:55 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

My fix for the review_reply_published webhook event fixed the main
serialization, but the comments were still using the wrong resources. This
change fixes those.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
This and serialize_reply do the same thing, except on different resources. Can we refactor this to take the review_key (as …	brennie	Nov. 5, 2015, 12:13 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/webhooks.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/webhooks.py

reviewboard/notifications/webhooks.py (Diff revision 1)

The issue has been dropped. Show all issues

This and serialize_reply do the same thing, except on different resources. Can we refactor this to take the review_key (as before), as well as the resource to use for serialization?

david Nov. 5, 2015, 12:12 p.m.

So this is what I was doing, but it would mean passing in all four resources now, which seemed like so much that having one method wasn't worth the trouble.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (8e9d4e6)