Fix Summary column compatibility with Python 2.6.

Review Request #7747 — Created Oct. 30, 2015 and submitted

Information

Review Board
release-2.5.x

Reviewers

The Summary column in 2.5 switched to using format_html(), but was using
it in a way that was incompatible with Python 2.6. This wasn't caught
due to the lack of unit tests.

We now use specific positional arguments ({0}, {1}) instead of generic
arguments ({}), in order to retain compatibility.

Unit tests were added for all variations on the column's rendered
output.

Unit tests pass on Python 2.6 and 2.7.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/datagrids/tests.py
        reviewboard/datagrids/columns.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/datagrids/tests.py
        reviewboard/datagrids/columns.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (1694583)
Loading...