Summary

Simplify save_image_to_storage.

Review Request #7711 — Created Oct. 19, 2015 and submitted Oct. 19, 2015, 1:55 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-0.8.x

Bugs

Depends On

Commit

f73210e...

Reviewers

Groups

djblets

People

Description

The save_image_to_storage template tag is one of the most ancient parts of
Djblets, and it was being way more complicated and fragile than necessary.
Because storage objects now provide an open method that returns a File
object, we can just write the image directly to storage rather than doing a
temporary file dance.

This also goes through and renames variables to not be called "file".

Testing Done

Used this with the PDF thumbnailer, which was encountering some raciness in my
setup.

Issues

Description	From	Last Updated
'os' imported but unused	reviewbot	Oct. 19, 2015, 1:24 p.m.
'tempfile' imported but unused	reviewbot	Oct. 19, 2015, 1:24 p.m.
'File' imported but unused	reviewbot	Oct. 19, 2015, 1:24 p.m.
We shouldn't use file here.	brennie	Oct. 19, 2015, 1:43 p.m.

Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/djblets_images.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/djblets_images.py

djblets/util/templatetags/djblets_images.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'os' imported but unused
```
djblets/util/templatetags/djblets_images.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'tempfile' imported but unused
```
djblets/util/templatetags/djblets_images.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'File' imported but unused
```

Description:

		The save_image_to_storage template tag is one of the most ancient parts of
		Djblets, and it was being way more complicated and fragile than necessary.
~		Because storage objects now provide an `open` method that returns a `File`
	~	Because storage objects now provide an `open` method that returns a `File`
		object, we can just write the image directly to storage rather than doing a
		temporary file dance.

Commit:

-	6b5f13089d27e2430656a1170235551de56d8808
+	fc0ddaf29775dfd31b80ff31475dfe12ba12bbec

Diff:

Revision 2 (+1 -11)

Show changes

djblets/util/templatetags/djblets_images.py

Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/djblets_images.py



Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/djblets_images.py

Ship it!

djblets/util/templatetags/djblets_images.py (Diff revision 2)
The issue has been resolved. Show all issues
```
We shouldn't use file here.
```

Description:

		The save_image_to_storage template tag is one of the most ancient parts of
		Djblets, and it was being way more complicated and fragile than necessary.
		Because storage objects now provide an `open` method that returns a `File`
		object, we can just write the image directly to storage rather than doing a
		temporary file dance.
	+
	+	This also goes through and renames variables to not be called "file".

Commit:

-	fc0ddaf29775dfd31b80ff31475dfe12ba12bbec
+	f73210e4ca293acd230c24c449eecbe32c4cd7f6

Diff:

Revision 3 (+15 -25)

Show changes

djblets/util/templatetags/djblets_images.py

Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/djblets_images.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/djblets_images.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (b245f63)