Fix some issues with movable region comments.
Review Request #7710 — Created Oct. 19, 2015 and submitted
While poking through stuff for Power Pack, I noticed that movable region
comments were broken for things other than images. As I dug deeper, I
discovered at least one instance of some confusing API.This change fixes three major issues:
- We were calling 'onClicked' by hand without passing an event object.
- The "selectionRegionSize" API was very confusing. I've changed the same of
the setter to make it clear we're setting a function that returns the region
size. - Fix a couple calls to
_superthat were causing infinite recursion.
Tested this in conjunction with a couple corresponding changes to Power Pack.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+16 -13) |
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/regionCommentBlockView.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/static/rb/js/models/regionCommentBlockModel.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/regionCommentBlockView.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/static/rb/js/models/regionCommentBlockModel.js
-
-
reviewboard/static/rb/js/views/regionCommentBlockView.js (Diff revision 2) While here, can you update this so it has a one-line summary, and an "Args" section?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+21 -13) |
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/regionCommentBlockView.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/static/rb/js/models/regionCommentBlockModel.js Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/regionCommentBlockView.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/static/rb/js/models/regionCommentBlockModel.js
-
-
reviewboard/static/rb/js/views/regionCommentBlockView.js (Diff revision 3) Description on the next line, since it wraps.
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/views/regionCommentBlockView.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/static/rb/js/models/regionCommentBlockModel.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/views/regionCommentBlockView.js reviewboard/static/rb/js/views/imageReviewableView.js reviewboard/static/rb/js/models/regionCommentBlockModel.js