Summary

Fix some issues with movable region comments.

Review Request #7710 — Created Oct. 19, 2015 and submitted Oct. 20, 2015, 12:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

49925a8...

Reviewers

Groups

reviewboard

People

Description

While poking through stuff for Power Pack, I noticed that movable region

comments were broken for things other than images. As I dug deeper, I

discovered at least one instance of some confusing API.
This change fixes three major issues:

We were calling 'onClicked' by hand without passing an event object.
The "selectionRegionSize" API was very confusing. I've changed the same of

  the setter to make it clear we're setting a function that returns the region

  size.
Fix a couple calls to _super that were causing infinite recursion.

Testing Done

Tested this in conjunction with a couple corresponding changes to Power Pack.

Issues

Description	From	Last Updated
double backquotes.	brennie	Oct. 19, 2015, 1:59 p.m.
While here, can you update this so it has a one-line summary, and an "Args" section?	chipx86	Oct. 19, 2015, 4:27 p.m.
Description on the next line, since it wraps.	chipx86	Oct. 20, 2015, 12:46 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.js
    reviewboard/static/rb/js/models/regionCommentBlockModel.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.js
    reviewboard/static/rb/js/models/regionCommentBlockModel.js

reviewboard/static/rb/js/views/regionCommentBlockView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
double backquotes.
```

Commit:

9b1adc73a1c9c1eac072c845ada7025f359fa408

f120dc33afa34ea6a788c7ef06a0d175050f72b9

Diff:

Revision 2 (+16 -13)

Show changes

	reviewboard/static/rb/js/models/regionCommentBlockModel.js
	reviewboard/static/rb/js/views/imageReviewableView.js
	reviewboard/static/rb/js/views/regionCommentBlockView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.js
    reviewboard/static/rb/js/models/regionCommentBlockModel.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.js
    reviewboard/static/rb/js/models/regionCommentBlockModel.js

reviewboard/static/rb/js/views/regionCommentBlockView.js (Diff revision 2)
The issue has been resolved. Show all issues
```
While here, can you update this so it has a one-line summary, and an "Args" section?
```

Commit:

f120dc33afa34ea6a788c7ef06a0d175050f72b9

49925a8e57ca98b3d1140498a266c1d003d3353e

Diff:

Revision 3 (+21 -13)

Show changes

	reviewboard/static/rb/js/models/regionCommentBlockModel.js
	reviewboard/static/rb/js/views/imageReviewableView.js
	reviewboard/static/rb/js/views/regionCommentBlockView.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.js
    reviewboard/static/rb/js/models/regionCommentBlockModel.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.js
    reviewboard/static/rb/js/models/regionCommentBlockModel.js

Ship it!

reviewboard/static/rb/js/views/regionCommentBlockView.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Description on the next line, since it wraps.
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (b063fc3)