• 
      

    Prevent double publishing from banner

    Review Request #7698 — Created Oct. 14, 2015 and submitted

    Information

    Review Board
    release-2.6.x

    Reviewers

    Now that the banner is an RB.SplitButtonView, we no longer want to
    register an event handler through the DraftBannerView's events
    object. We just use the event handler given to the RB.SplitButtonView
    constructor. Previously, the handler for publishing was being called
    twice, leading to a confusing permission error. Removing the event
    handler fixed the issue.

    Ran unit tests.
    Ran JS tests.
    Could no longer trigger the permission error after applying this patch.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/draftReviewBannerView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/draftReviewBannerView.js
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.6.x (ee758a5)