Fix error message when Python isn't properly configured to proxy server.
Review Request #7689 — Created Oct. 10, 2015 and discarded — Latest diff uploaded
Better handled 'URLError' error message by placing line 'data = e.read()' in try block instead of outside of it. This way, when there is a URLError exception, it will not raise an error with URLError calling read().
Tested by reloading browser (Chrome).
Ran ./reviewboard/manage.py test -- reviewboard.hostingsvcs.tests and all 167 tests passed.
Diff Revision 6
This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.
orig
1
2
3
4
5
6
7
| reviewboard/hostingsvcs/github.py |
|---|
| reviewboard/hostingsvcs/kiln.py |
|---|
| reviewboard/hostingsvcs/tests.py |
|---|