Only send public flag when pubishing reviews from banner

Review Request #7678 — Created Oct. 5, 2015 and submitted — Latest diff uploaded

Information

Review Board
release-2.5.x

Reviewers

Publishing from the `RB.DraftBannerReviewView` now only sends the
`public` flag to the server during the save call. This fixes a bug where
publishing through the banner would sometimes result in text being
rendered as raw HTML. This occurred because the `RB.ReviewDialogView`
would save the `body_top` or `body_bottom` text and request HTML back so
that it could render it. This would end up saved in the
`RB.DraftReviewModel` and, when published via the banner, it would send
this rendered HTML back to the server as the `body_top` or `body_bottom`
text.

The bug no longer reproduces with this patch applied. Instead, reviews
are published as intended (without HTML markup).

    Loading...