• 
      

    Only send public flag when pubishing reviews from banner

    Review Request #7678 — Created Oct. 6, 2015 and submitted

    Information

    Review Board
    release-2.5.x

    Reviewers

    Publishing from the `RB.DraftBannerReviewView` now only sends the
    `public` flag to the server during the save call. This fixes a bug where
    publishing through the banner would sometimes result in text being
    rendered as raw HTML. This occurred because the `RB.ReviewDialogView`
    would save the `body_top` or `body_bottom` text and request HTML back so
    that it could render it. This would end up saved in the
    `RB.DraftReviewModel` and, when published via the banner, it would send
    this rendered HTML back to the server as the `body_top` or `body_bottom`
    text.

    The bug no longer reproduces with this patch applied. Instead, reviews
    are published as intended (without HTML markup).

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/draftReviewBannerView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/draftReviewBannerView.js
      
      
    2. 
        
    chipx86
    1. Change looks fine. The description looks to be escaped Markdown. It might also be nice to break down the description into a couple paragraphs (maybe one describing the problem, another describing the fix), so it's easier to obsorb.

    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (80161e5)