Draft Review Board 2.5 release notes.

Review Request #7677 — Created Oct. 5, 2015 and submitted

Information

Review Board
release-2.5.x
b9606c6...

Reviewers

This adds a draft of the release notes for the 2.5 final release. This merges
all of the beta/RC release notes together, and includes all changes pushed
since RC1. Currently this has the text content. I'm working on adding
screenshots next.

Built HTML and looked at the output.

Description From Last Updated

Let's add, "or your database will become corrupt."

chipx86chipx86

Also user pages. The listing of the pages (which is being referred to as features, but should probably be "pages") …

chipx86chipx86

I know this was here before, but how about "increase the default size to allow for more room to write …

chipx86chipx86

Let's expand upon this and really talk about what's offered here. Users can navigate through Review Board with a side …

chipx86chipx86

Casing should match the other sections.

chipx86chipx86

"is now optional"

chipx86chipx86

I know this was here before, but for the final release notes, I think we can get rid of the …

chipx86chipx86

Let's say "Improvements to the Review Dialog"

chipx86chipx86

"and modern versions ..."

chipx86chipx86

Let's use this opportunity to do some advertisement for Splat here. Something like: "In upcoming releases, we'll be adding support …

chipx86chipx86

Let's reword part of this: "Updating a review request with a new diff through the Review Board UI has become …

chipx86chipx86

How about "Double-clicking anywhere on a line ..." Also, we should break this into a summary and a separate paragraph …

chipx86chipx86

"now show", and missing a period.

chipx86chipx86

Selling this more, let's end with, ".. rather than the raw Markdown, showing how your comment will look when published."

chipx86chipx86

What do you think about naming this "Live HD Thumbnails"? "HD" for the Retina stuff, "Live" for the scroll-on-hover.

chipx86chipx86

Let's put a paragraph break right before this sentence, to improve skimming of the feature addition.

chipx86chipx86

How about, "... without having to delete the old attachment before uploading the new one."

chipx86chipx86

We no longer have the down arrow. Now you simply hover over the attachment and click Update.

chipx86chipx86

What do you think about shortening to "Diffs for Image Attachments" and, later, "Diffs for Text Attachments"?

chipx86chipx86

Let's say, in another paragraph: "Working with text-based diffs is very similar to using the diff viewer. You can leave …

chipx86chipx86

Let's get rid of "Regions".

chipx86chipx86

Here, too.

chipx86chipx86

"... or want to cover a different area of your image."

chipx86chipx86

Missing period. How about, "See all reviews by a user at a glance."

chipx86chipx86

"Smarter" ? Missing period.

chipx86chipx86

Missing period.

chipx86chipx86

This is worth mentioning in its own section, as I'm sure many users have wanted this, particularly if coming from …

chipx86chipx86

How about, "The New Review Request page now shows all branches and commits for repositories hosted on Bitbucket. Clicking a …

chipx86chipx86

We're not consistent here with the bug reference location. FWIW, we've been putting the bug number on the summary line …

chipx86chipx86

Let's get rid of "now," because we used that in the sentence above.

chipx86chipx86

Let's remove "also," since we said that just before this sentence, and it's not necessary here.

chipx86chipx86

Let's link to the docs for the templating language. We should probably also link to our own docs on this …

chipx86chipx86

We should be consistent in capitalization of "webhook".

chipx86chipx86

We can probably remove the second "widget."

chipx86chipx86

Let's add a little to this, saying "When configured, all new file attachments will be uploaded to Swift instead of …

chipx86chipx86

Missing period.

chipx86chipx86

Let's add on, "This will also help reduce database upgrade times in the future".

chipx86chipx86

After this, let's add: "Newly-uploaded diffs will be stored in the new format, and visiting existing diffs will automatically convert …

chipx86chipx86

"... stored diffs to the new format."

chipx86chipx86

We might want a paragraph before the feature bullet point that just says something like: "This release contains numerous usablity …

chipx86chipx86

Let's have a paragraph detailing that this is for the new revisioned file attachments (with a link to that section).

chipx86chipx86

Let's add something like "See Web Hooks [with link] for more information on this new feature."

chipx86chipx86

We shouldn't have the bullet point here, or we shouldn't add the section header. How about a "New Hooks" section …

chipx86chipx86

Can we have both the bugs wrapped to the next line?

chipx86chipx86

Worth saying in the next paragraph that this was working for submitted review requests but not discarded ones.

chipx86chipx86

Remove "(in-development)"

chipx86chipx86

This should be in Title Case, while you're here.

chipx86chipx86

This should go before the header.

chipx86chipx86

Should go before the section header.

chipx86chipx86

No need for "File Attachment" here, since the context will be clear.

chipx86chipx86

Should go above the section title.

chipx86chipx86

Should go above the section title.

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/index.rst
        docs/releasenotes/2.5.rst
        AUTHORS
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/index.rst
        docs/releasenotes/2.5.rst
        AUTHORS
    
    
  2. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/2.5.rst
        docs/releasenotes/index.rst
        docs/releasenotes/_static/images/2.5/2.5-review-request-details.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details@2x.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments@2x.png
        AUTHORS
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/2.5.rst
        docs/releasenotes/index.rst
        docs/releasenotes/_static/images/2.5/2.5-review-request-details.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details@2x.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments@2x.png
        AUTHORS
    
    
  2. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/_static/images/2.5/2.5-image-diffs.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details@2x.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments@2x.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments.png
        docs/releasenotes/index.rst
        docs/releasenotes/_static/images/2.5/2.5-expand-context.gif
        docs/releasenotes/2.5.rst
        AUTHORS
        docs/releasenotes/_static/images/2.5/2.5-image-diffs@2x.png
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/_static/images/2.5/2.5-image-diffs.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details@2x.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments@2x.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments.png
        docs/releasenotes/index.rst
        docs/releasenotes/_static/images/2.5/2.5-expand-context.gif
        docs/releasenotes/2.5.rst
        AUTHORS
        docs/releasenotes/_static/images/2.5/2.5-image-diffs@2x.png
    
    
  2. 
      
chipx86
  1. Thanks for taking this on! :D

    Got some suggestions to help reword bits taken from earlier release notes, now that this will probably be more carefully read by more users. Aiming to better advertise the benefits of more of the features.

    Most of these suggestions are pretty small.

  2. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Let's add, "or your database will become corrupt."

  3. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
     
     
    Show all issues

    Also user pages.

    The listing of the pages (which is being referred to as features, but should probably be "pages") kind of feels.. I don't know, terse? Something. It's the capitalization and "New Review Request" specifically.

    How about:

    • The dashboard
    • Review requests and reviews
    • The diff viewer
    • The New Review Request page
  4. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    I know this was here before, but how about "increase the default size to allow for more room to write comments"?

  5. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    Let's expand upon this and really talk about what's offered here.

    Users can navigate through Review Board with a side menu, activated by tapping the hamburger menu.

    Through the mobile UI, you can participate in discussions on existing reviews while out and about.

    The diff viewer, review dialog, and attachment review experiences ar not yet mobile-friendly. We'll be unveiling updates in the future that will make it easy to review code and attachments from your phone or tablet.

  6. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Casing should match the other sections.

  7. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    "is now optional"

  8. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    I know this was here before, but for the final release notes, I think we can get rid of the first part of this sentence.

  9. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Let's say "Improvements to the Review Dialog"

  10. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    "and modern versions ..."

  11. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
     
    Show all issues

    Let's use this opportunity to do some advertisement for Splat here. Something like:

    "In upcoming releases, we'll be adding support for additional bug trackers, such as Splat, our new friendly bug tracker service currently in development."

  12. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    Let's reword part of this:

    "Updating a review request with a new diff through the Review Board UI has become a lot easier. The Update Diff dialog has been redesigned to mirror the abilities of the New Review Request page.

    To upload a new diff, you can either drag-and-drop it onto the dialog, or browse your file system. The diff will be automatically checked, showing any errors or requesting additional information (such as a parent diff or Subversion base path) if needed.

  13. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    How about "Double-clicking anywhere on a line ..."

    Also, we should break this into a summary and a separate paragraph describing the feature, like we have elsewhere.

  14. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    "now show", and missing a period.

  15. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    Selling this more, let's end with, ".. rather than the raw Markdown, showing how your comment will look when published."

  16. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    What do you think about naming this "Live HD Thumbnails"? "HD" for the Retina stuff, "Live" for the scroll-on-hover.

  17. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Let's put a paragraph break right before this sentence, to improve skimming of the feature addition.

  18. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    How about, "... without having to delete the old attachment before uploading the new one."

  19. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    We no longer have the down arrow. Now you simply hover over the attachment and click Update.

  20. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    What do you think about shortening to "Diffs for Image Attachments" and, later, "Diffs for Text Attachments"?

  21. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
     
    Show all issues

    Let's say, in another paragraph:

    "Working with text-based diffs is very similar to using the diff viewer. You can leave comments across multiple lines, see indentation-only changes or moved blocks of lines, and more."

  22. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Let's get rid of "Regions".

  23. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Here, too.

  24. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    "... or want to cover a different area of your image."

  25. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Missing period.

    How about, "See all reviews by a user at a glance."

  26. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    "Smarter" ?

    Missing period.

  27. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Missing period.

  28. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    This is worth mentioning in its own section, as I'm sure many users have wanted this, particularly if coming from GitHub.

  29. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    How about, "The New Review Request page now shows all branches and commits for repositories hosted on Bitbucket. Clicking a commit will post it for review, making it easy to review changes made prior to using Review Board or to review changes sitting on another branch."

    We should also link Bitbucket.

  30. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    We're not consistent here with the bug reference location.

    FWIW, we've been putting the bug number on the summary line for bullet points in all previous release notes.

    Also, the summary took me a couple tries to read. How about, "The display name for a group is now shown on the group page."

  31. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Let's get rid of "now," because we used that in the sentence above.

  32. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Let's remove "also," since we said that just before this sentence, and it's not necessary here.

  33. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Let's link to the docs for the templating language.

    We should probably also link to our own docs on this further down.

  34. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    We should be consistent in capitalization of "webhook".

  35. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    We can probably remove the second "widget."

  36. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Let's add a little to this, saying "When configured, all new file attachments will be uploaded to Swift instead of on the Review Board server. This helps when scaling Review Board out to multiple servers, and reduces load on the Review Board server."

  37. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Missing period.

  38. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
     
    Show all issues

    Let's add on, "This will also help reduce database upgrade times in the future".

  39. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
     
    Show all issues

    After this, let's add:

    "Newly-uploaded diffs will be stored in the new format, and visiting existing diffs will automatically convert them to the new format as well."

  40. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    "... stored diffs to the new format."

  41. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    We might want a paragraph before the feature bullet point that just says something like:

    "This release contains numerous usablity improvements for both desktop and mobile devices as part of the new visual redesign. See Design Update above."

    With "Design Update" linking.

  42. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    Let's have a paragraph detailing that this is for the new revisioned file attachments (with a link to that section).

  43. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
    Show all issues

    Let's add something like "See Web Hooks [with link] for more information on this new feature."

  44. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
     
     
    Show all issues

    We shouldn't have the bullet point here, or we shouldn't add the section header.

    How about a "New Hooks" section (for AdminWidgetHook, WebAPICapabilitiesHook, and the e-mail hooks) and an "Extension Web APIs" (or something) section?

  45. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    Can we have both the bugs wrapped to the next line?

  46. docs/releasenotes/2.5.rst (Diff revision 3)
     
     
     
    Show all issues

    Worth saying in the next paragraph that this was working for submitted review requests but not discarded ones.

  47. docs/releasenotes/index.rst (Diff revision 3)
     
     
    Show all issues

    Remove "(in-development)"

  48. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/_static/images/2.5/2.5-image-diffs.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details@2x.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments@2x.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments.png
        docs/releasenotes/index.rst
        docs/releasenotes/_static/images/2.5/2.5-expand-context.gif
        docs/releasenotes/2.5.rst
        AUTHORS
        docs/releasenotes/_static/images/2.5/2.5-image-diffs@2x.png
        docs/manual/admin/configuration/webhooks.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/_static/images/2.5/2.5-image-diffs.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details@2x.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments@2x.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments.png
        docs/releasenotes/index.rst
        docs/releasenotes/_static/images/2.5/2.5-expand-context.gif
        docs/releasenotes/2.5.rst
        AUTHORS
        docs/releasenotes/_static/images/2.5/2.5-image-diffs@2x.png
        docs/manual/admin/configuration/webhooks.rst
    
    
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    This should be in Title Case, while you're here.

  3. Show all issues

    This should go before the header.

  4. docs/releasenotes/2.5.rst (Diff revision 4)
     
     
    Show all issues

    Should go before the section header.

  5. docs/releasenotes/2.5.rst (Diff revision 4)
     
     
    Show all issues

    No need for "File Attachment" here, since the context will be clear.

  6. docs/releasenotes/2.5.rst (Diff revision 4)
     
     
    Show all issues

    Should go above the section title.

  7. docs/releasenotes/2.5.rst (Diff revision 4)
     
     
    Show all issues

    Should go above the section title.

  8. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/_static/images/2.5/2.5-image-diffs.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details@2x.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments@2x.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments.png
        docs/releasenotes/index.rst
        docs/releasenotes/_static/images/2.5/2.5-expand-context.gif
        docs/releasenotes/2.5.rst
        AUTHORS
        docs/releasenotes/_static/images/2.5/2.5-image-diffs@2x.png
        docs/manual/admin/configuration/webhooks.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        docs/releasenotes/conf.py
    
    Ignored Files:
        docs/releasenotes/_static/images/2.5/2.5-image-diffs.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details@2x.png
        docs/releasenotes/_static/images/2.5/2.5-review-request-details.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments@2x.png
        docs/releasenotes/_static/images/2.5/2.5-file-attachments.png
        docs/releasenotes/index.rst
        docs/releasenotes/_static/images/2.5/2.5-expand-context.gif
        docs/releasenotes/2.5.rst
        AUTHORS
        docs/releasenotes/_static/images/2.5/2.5-image-diffs@2x.png
        docs/manual/admin/configuration/webhooks.rst
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (8c21253)
Loading...