Switch to a custom build of CodeMirror

Review Request #7670 — Created Oct. 1, 2015 and submitted

Information

Review Board
release-2.5.x

Reviewers

This patch switches out CodeMirror for a custom build based on version
5.5.0. A patch has been applied that allows Markdown and
GitHub-flavoured markdown editors to override the styles of any
generated elements. We use this to fix the previous workaround of code
blocks being rendered as comments (i.e., they were italicized) and to
fix the styling on lists (they are no longer styled).

NB: Once the patch is accepted upstream and a new release is done
(which should be 5.7.1) we will switch back to using the official
source tree.

Ran CodeMirror unit tests before building.

Manually verified that code blocks are not italicized.
Manually verified thats lists are not styled.

Description From Last Updated

Maybe call these "rb-markdown-<thing>" ?

chipx86chipx86

I'd like to keep the version number in this. We can do "5.5-custom".

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/codemirror.min.js
        reviewboard/static/lib/js/README.codemirror
        reviewboard/static/rb/js/ui/views/textEditorView.js
        reviewboard/static/lib/js/codemirror-5.5.min.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/codemirror.min.js
        reviewboard/static/lib/js/README.codemirror
        reviewboard/static/rb/js/ui/views/textEditorView.js
        reviewboard/static/lib/js/codemirror-5.5.min.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/static/rb/js/ui/views/textEditorView.js (Diff revision 1)
     
     
     
     
     

    Maybe call these "rb-markdown-<thing>" ?

  3. reviewboard/staticbundles.py (Diff revision 1)
     
     

    I'd like to keep the version number in this. We can do "5.5-custom".

  4. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/codemirror-5.5-custom.min.js
        reviewboard/static/lib/js/README.codemirror
        reviewboard/static/rb/js/ui/views/textEditorView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/codemirror-5.5-custom.min.js
        reviewboard/static/lib/js/README.codemirror
        reviewboard/static/rb/js/ui/views/textEditorView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/codemirror-5.5-custom.min.js
        reviewboard/static/lib/js/README.codemirror
        reviewboard/static/rb/js/ui/views/textEditorView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/lib/js/codemirror-5.5-custom.min.js
        reviewboard/static/lib/js/README.codemirror
        reviewboard/static/rb/js/ui/views/textEditorView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (db3386f)
Loading...